[16.0] [ADD] sale_commission_margin: Deduct commission from margin #591
Conversation
|
Hi @pedrobaeza, |
luisDIXMIT
force-pushed
the
16.0-add-sale_commission_margin
branch
from
cd26f5f to
20753b2
Compare
|
@OCA/crm-sales-marketing-maintainers |
luisDIXMIT
force-pushed
the
16.0-add-sale_commission_margin
branch
from
20753b2 to
2fa6b43
Compare
luisDIXMIT
changed the title
luisDIXMIT
force-pushed
the
16.0-add-sale_commission_margin
branch
from
2fa6b43 to
8bed888
Compare
| @@ -4,6 +4,8 @@ | |||
| <field name="name">sale.agent.order.inherit.form</field> | |||
| <field name="model">sale.order</field> | |||
| <field name="inherit_id" ref="sale.view_order_form" /> | |||
| <field name="priority" eval="15" /> | |||
| <field name="mode">primary</field> | |||
There was a problem hiding this comment.
Why primary?
You should add the change directly in your module
There was a problem hiding this comment.
Because in that case, it has no effect. I looked into the Odoo documentation and supposed it is due to the following:
View matching
if a view is requested by (model, type), the view with the right model and type, mode=primary and the lowest priority is matched.when a view is requested by id, if its mode is not primary its closest parent with mode primary is matched.
There was a problem hiding this comment.
This is not correct. Please don't change it.
There was a problem hiding this comment.
Due to your suggestions and after several attempts with different approaches, I think the cleanest solution to show the commission total before the margin, without completely changing the view logic and while keeping it within my module, is to use the position attribute to move the field to a different node. WDY?
There was a problem hiding this comment.
I have also squashed all commits into one because it is all about my module.
luisDIXMIT
force-pushed
the
16.0-add-sale_commission_margin
branch
from
8bed888 to
2e62d68
Compare
This addon allows commissions to be deducted from the margin.
Because precomputed fields must depend on other precomputed fields, some computed fields in the commission module have been established as precomputed.
Issue #153