Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_commission_pricelist: Migration to 17.0 #595

Open
wants to merge 40 commits into
base: 17.0
Choose a base branch
from
Open

[MIG] sale_commission_pricelist: Migration to 17.0 #595

wants to merge 40 commits into from

Conversation

GabbasovDinar
Copy link
Member

No description provided.

carlosdauden and others added 30 commits February 3, 2025 12:16
@carlosdauden @GabbasovDinar
[ADD] sale_commission_pricelist: New module that assign commission to…
26e0de2 
… pricelist item
@pedrobaeza @GabbasovDinar
[FIX] sale_commission_pricelist: Make this to work on button recompute
26fe3de
@oca-transbot @GabbasovDinar
OCA Transbot updated translations from Transifex
bc8df8b
@eLBati @GabbasovDinar
porting sale_commission_pricelist to 11.0
a615030
@oca-travis @GabbasovDinar
[UPD] Update sale_commission_pricelist.pot
4708b3c
@OCA-git-bot @GabbasovDinar
[UPD] README.rst
784ee9c
@rschnapka @GabbasovDinar
Added translation using Weblate (German)
0a5b4e9
@ernestotejeda @GabbasovDinar
[MIG] sale_commission_pricelist: Migration to 12.0
ec3d984
@oca-travis @GabbasovDinar
[UPD] Update sale_commission_pricelist.pot
2f34bc5
@oca-transbot @GabbasovDinar
Update translation files
80ad2a4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/
@eLBati @GabbasovDinar
Translated using Weblate (Italian)
e73c2ec 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/it/
@OCA-git-bot @GabbasovDinar
[UPD] README.rst
756a8a3
@liweijie0812 @GabbasovDinar
Added translation using Weblate (Chinese (Simplified))
183a056
@liweijie0812 @GabbasovDinar
Translated using Weblate (Chinese (Simplified))
90eda43 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/zh_CN/
@pedrocs-exo @GabbasovDinar
Added translation using Weblate (Portuguese)
5a77341
@pedrocs-exo @GabbasovDinar
Translated using Weblate (Portuguese)
ead4095 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt/
@marcelsavegnago @GabbasovDinar
Added translation using Weblate (Portuguese (Brazil))
f539b86
@marcelsavegnago @GabbasovDinar
Translated using Weblate (Portuguese (Brazil))
3c61e2b 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt_BR/
@marcelsavegnago @GabbasovDinar
Translated using Weblate (Portuguese (Brazil))
8c3f513 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-12.0/commission-12.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt_BR/
@feketemihai @GabbasovDinar
[IMP] sale_commission_pricelist: black, isort, prettier
149148d
@feketemihai @GabbasovDinar
[MIG] sale_commission_pricelist: Migration to 13.0
512b20f
@oca-travis @GabbasovDinar
[UPD] Update sale_commission_pricelist.pot
36126d8
@OCA-git-bot @GabbasovDinar
[UPD] README.rst
991a7be
@oca-transbot @GabbasovDinar
Update translation files
2d1663e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-13.0/commission-13.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_pricelist/
@oca-transbot @GabbasovDinar
Update translation files
b44597a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-13.0/commission-13.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_pricelist/
@ibuioli @GabbasovDinar
Added translation using Weblate (Spanish (Argentina))
ce7ab59
@ibuioli @GabbasovDinar
Translated using Weblate (Spanish (Argentina))
50286db 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-13.0/commission-13.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_pricelist/es_AR/
@feketemihai @GabbasovDinar
Update inherited view with new field.
68e70e3
@OCA-git-bot @GabbasovDinar
sale_commission_pricelist 13.0.1.1.0
0f4f82a
@cjallais @GabbasovDinar
[IMP] sale_commission_pricelist: black, isort, prettier
4c8570f
cjallais and others added 9 commits February 3, 2025 12:19
@cjallais @GabbasovDinar
[MIG] sale_commission_pricelist: Migration to 14.0
e3b9b3f
@oca-travis @GabbasovDinar
[UPD] Update sale_commission_pricelist.pot
73e149d
@OCA-git-bot @GabbasovDinar
[UPD] README.rst
7aaa43c
@primes2h @GabbasovDinar
Translated using Weblate (Italian)
2c40eab 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/
@GabbasovDinar
Translated using Weblate (Portuguese (Brazil))
39b7000 
Currently translated at 100.0% (3 of 3 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/pt_BR/
@weblate @GabbasovDinar
Update translation files
58e50d6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/
@francesco-ooops @GabbasovDinar
Translated using Weblate (Italian)
ff855d9 
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/
@Ivorra78 @GabbasovDinar
Translated using Weblate (Spanish)
fd23df1 
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-14.0/commission-14.0-sale_commission_pricelist
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/es/
@GabbasovDinar
[IMP] sale_commission_pricelist: pre-commit auto fixes
ce142ac
@GabbasovDinar GabbasovDinar mentioned this pull request Feb 3, 2025
Open
7 tasks
@GabbasovDinar GabbasovDinar force-pushed the 17.0-t4314-sale_commission_pricelist-migration branch 5 times, most recently from b7348a3 to 099172d Compare February 6, 2025 09:54
Bearnard21
Bearnard21 approved these changes Feb 7, 2025
View reviewed changes
Copy link

@Bearnard21 Bearnard21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionlity LGTM

geomer198
geomer198 suggested changes Feb 7, 2025
View reviewed changes
sale_commission_pricelist/models/sale_order_line_agent.py Outdated
res = super()._compute_commission_id()
for record in self:
commission = record.object_id._get_commission_from_pricelist()
if commission:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better do like this:

record.commission_id = commission_id or record.agent_id.commission_id

@GabbasovDinar GabbasovDinar force-pushed the 17.0-t4314-sale_commission_pricelist-migration branch from 099172d to f7afc89 Compare February 10, 2025 07:12
hoangtrann
hoangtrann approved these changes Feb 10, 2025
View reviewed changes
Copy link

@hoangtrann hoangtrann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

geomer198
geomer198 approved these changes Feb 10, 2025
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangtrann hoangtrann hoangtrann approved these changes

@geomer198 geomer198 geomer198 approved these changes

@Bearnard21 Bearnard21 Bearnard21 approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.