Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] website_sale_hide_empty_category: Migration to version 18.0 #1011

Merged

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Jan 28, 2025

cc @Tecnativa TT54389

@CarlosRoca13 @chienandalu please review

Ted Salmon and others added 16 commits January 28, 2025 17:42
* [ADD] website_sale_category_empty: Create module
* Add module to hide categories that have no products associated with them

* [FIX] website_sale_hide_empty_category: PR Fix
* Add trailing comma to manifest
* Rename Module
Currently translated at 100.0% (2 of 2 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_empty_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_empty_category/nl/
Currently translated at 100.0% (2 of 2 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_empty_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_empty_category/ca/
Currently translated at 100.0% (2 of 2 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_hide_empty_category
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_hide_empty_category/es/
- Create setUpClass method if necessary
- Switch to setUpClass for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
@pedrobaeza
Copy link
Member

/ocabot migration website_sale_hide_empty_category

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 28, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 28, 2025
16 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_hide_empty_category branch from 75afd32 to 8efc1cd Compare January 28, 2025 17:22
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_hide_empty_category branch from 8efc1cd to c53530c Compare January 30, 2025 12:18
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1011-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d685ceb into OCA:18.0 Feb 7, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7586bc0. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-website_sale_hide_empty_category branch February 7, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.