-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] website_sale_infinite_scroll: new module #784
[14.0][ADD] website_sale_infinite_scroll: new module #784
Conversation
2d0bcf4
to
5feb186
Compare
5feb186
to
f7e5705
Compare
b61d8a2
to
6550544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to USAGE
Go to /shop page > Customize > activate "Infinite Products Scroll"
b161472
to
8ecd76b
Compare
8ecd76b
to
be1e802
Compare
7161b82
to
dc8db08
Compare
@OCA/e-commerce-maintainers good for merge? |
@OCA/e-commerce-maintainers what do you say? |
@OCA/e-commerce-maintainers go? :) |
@pedrobaeza can you merge based on existing reviews? thanks! |
Well, I don't like too much this feature "as user", as this doesn't serve for linking pages to others, as there are no pages, so you can't "bookmark" anything in the list, but being a separate module, you can choose to not install it: /ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-784-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-784-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Can you rebase on current main branch? |
|
c333168
to
7b35334
Compare
Please check the CI. |
Failing CI is not due to this module. There's another problem that affects all PR on v14, I'm fixing it here: #839 |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 874e570. Thanks a lot for contributing to OCA. ❤️ |
This module removes pagination in /shop page and replaces it with infinite scrolling of products.