Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] website_sale_infinite_scroll: new module #784

Conversation

dessanhemrayev
Copy link

@dessanhemrayev dessanhemrayev commented Apr 20, 2023

This module removes pagination in /shop page and replaces it with infinite scrolling of products.

@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2482-website_sale_infinite_scroll-add_module branch 5 times, most recently from 2d0bcf4 to 5feb186 Compare April 23, 2023 22:54
@dessanhemrayev dessanhemrayev marked this pull request as ready for review April 23, 2023 22:54
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2482-website_sale_infinite_scroll-add_module branch from 5feb186 to f7e5705 Compare April 23, 2023 23:53
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2482-website_sale_infinite_scroll-add_module branch 12 times, most recently from b61d8a2 to 6550544 Compare May 8, 2023 12:17
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to USAGE

Go to /shop page > Customize > activate "Infinite Products Scroll"

website_sale_infinite_scroll/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
website_sale_infinite_scroll/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2482-website_sale_infinite_scroll-add_module branch 3 times, most recently from b161472 to 8ecd76b Compare May 10, 2023 16:55
website_sale_infinite_scroll/controllers/main.py Outdated Show resolved Hide resolved
website_sale_infinite_scroll/controllers/main.py Outdated Show resolved Hide resolved
website_sale_infinite_scroll/controllers/main.py Outdated Show resolved Hide resolved
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2482-website_sale_infinite_scroll-add_module branch from 8ecd76b to be1e802 Compare May 10, 2023 19:46
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2482-website_sale_infinite_scroll-add_module branch 3 times, most recently from 7161b82 to dc8db08 Compare May 13, 2023 12:55
@francesco-ooops
Copy link
Contributor

@OCA/e-commerce-maintainers good for merge?

@francesco-ooops
Copy link
Contributor

@OCA/e-commerce-maintainers what do you say?

@francesco-ooops
Copy link
Contributor

@OCA/e-commerce-maintainers go? :)

@francesco-ooops
Copy link
Contributor

@pedrobaeza can you merge based on existing reviews?

thanks!

@pedrobaeza pedrobaeza added this to the 14.0 milestone Aug 28, 2023
@pedrobaeza
Copy link
Member

Well, I don't like too much this feature "as user", as this doesn't serve for linking pages to others, as there are no pages, so you can't "bookmark" anything in the list, but being a separate module, you can choose to not install it:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-784-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 28, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-784-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-784-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 28, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-784-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Can you rebase on current main branch?

@francesco-ooops
Copy link
Contributor

Can you rebase on current main branch?

@dessanhemrayev

@Aldeigja Aldeigja force-pushed the 14.0-t2482-website_sale_infinite_scroll-add_module branch from c333168 to 7b35334 Compare August 28, 2023 17:29
@pedrobaeza
Copy link
Member

Please check the CI.

@aleuffre
Copy link

aleuffre commented Sep 6, 2023

Failing CI is not due to this module. There's another problem that affects all PR on v14, I'm fixing it here: #839

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-784-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 60c80b8 into OCA:14.0 Sep 6, 2023
2 of 4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 874e570. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants