[16.0][MIG] website_sale_order_type: Migration to version 16.0 #826
Conversation
Without this patch, it's easy that the tour fails randomly due to a timeout when generating the sales order report. These assets can take a long time, increasing when more addons are installed.
In an integrated database, this patch makes the test go from this log:
2020-11-06 10:34:53,941 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:34:53] "POST /payment/transfer/feedback HTTP/1.1" 302 - 730 4.368 11.800
To this one:
2020-11-06 10:32:55,517 34 INFO devel werkzeug: 127.0.0.1 - - [06/Nov/2020 10:32:55] "POST /payment/transfer/feedback HTTP/1.1" 302 - 479 2.906 5.771
That's about 50% the time.
In the same patch, I remove the `self.env` patch that was only needed for Odoo v11 and lower.
With the old tour, timeout problems started to occur, even with 7830084 This partially reverts that, and instead uses a simpler tour to test the creation of the SO. TT26399
If we don't trigger the onchanges, we won't get some of the default values that the order type has defined TT30235
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-15.0/e-commerce-15.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_order_type/
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_order_type Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_order_type/es/
|
This one shouldn't be needed if the field is computed writable (which I think it is), but if not, the patch should be to make it on the base module, like we have done with this one: OCA/sale-workflow@788e2bc |
Yes, this can be a good chance to fix that |
|
Fix made in OCA/sale-workflow#2639 |
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_order_type
branch
from
ea2a78c
to
967c785
Compare
|
This migration PR has been reopened as the fix made in sale_order_type did not cover the e-commerce flow. Therefore this module is still needed. @pedrobaeza can you check it too? I have decided to extend the methods that set the values that are overwritten in the e-commerce flow instead of the method that prepares the dictionary and calls these methods so that in case they are called from anywhere else the intended effect of this module is still in effect. |
|
/ocabot migration website_sale_order_type |
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_order_type
branch
from
967c785
to
4f8b857
Compare
|
This PR has the |
pilarvargas-tecnativa
force-pushed
the
16.0-mig-website_sale_order_type
branch
from
4f8b857
to
79fc3e8
Compare
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at de8bc01. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT44380
@stefan-tecnativa @chienandalu please review :)