[16.0][ADD] New module website sale product image sample #827
Conversation
There was a problem hiding this comment.
Nice addon @manuelcalerosolis Some comments
- I couldn't set the attribute image, is the view extension missing?
| @@ -0,0 +1,5 @@ | |||
| * For the correct functioning of the module I had to rewrite .css_attribute_color, impacting the way of representing the selection by colors. | |||
There was a problem hiding this comment.
What about adding an extra class that overrides those styles only for the image thumbnails?
|
The image is obtained from the variant (product.product), it is so by customer requirements.  Buscar esto en Google |
Ah, that makes sense :) About the styles, did you explore adding an extra class so you don't need to change the base one? |
|
I tried creating a new css .css_attribute_product_image but the thumbnail image doesn't stay selected. The problem is this line
I think the "combination" variable doesn't work with another css selector
|
Yes, that's because the js logic uses that class as a selector. I meant an additional class that would add up/override the other styles. Something like this: t-attf-class="css_attribute_color css_attribute_product_image #{'active' if ptav in combination else ''} #{'custom_value' if ptav.is_custom else ''}" |
|
Thanks for your help, I have created a new .css and added it to the old one as you indicated, now it works correctly. |
manuelcalerosolis
changed the title
|
@pedrobaeza Can this one be merged? THX |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-827-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f22fd97. Thanks a lot for contributing to OCA. ❤️ |
This module allows you to select the product variants by displaying a thumbnail image.
Quick sample