[14.0][IMP][FIX] website_sale_product_assortment: handle multiple assortments #838
+239
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @CarlosRoca13, |
aleuffre
force-pushed
the
14.0-assortment-fix
branch
4 times, most recently
from
b84e956
to
c77c157
Compare
|
Failing CI is due to another issue that I'm fixing here: #839 |
|
@CarlosRoca13 what do you think of this one? |
aleuffre
force-pushed
the
14.0-assortment-fix
branch
from
c77c157
to
9c85741
Compare
CarlosRoca13
approved these changes
Sep 7, 2023
pedrobaeza
reviewed
Sep 7, 2023
| assortment = assortments[0] | ||
| res["message_unavailable"] = assortment.message_unavailable | ||
| res["assortment_information"] = assortment.assortment_information | ||
|
|
There was a problem hiding this comment.
Please don't add empty lines inside a method.
aleuffre
force-pushed
the
14.0-assortment-fix
branch
2 times, most recently
from
8c88f00
to
4213656
Compare
This commit changes the way multiple assortments are handled and fixes a couple of bugs in the process. The current version of the module is not able to handle multiple assortments, especially ones that are exclusive (e.g. one assortment with all consumable products and one with all services) and the module seemingly breaks, ignoring the selected rule (e.g. no_show) With these changes, that behaviour is fixed, and additionally assortments for the same website and partner and merged in a logical OR.
aleuffre
force-pushed
the
14.0-assortment-fix
branch
from
4213656
to
ddbdd42
Compare
|
Thanks for the fix and the regression tests: /ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 49f9443. Thanks a lot for contributing to OCA. ❤️ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way multiple assortments are handled and fixes a couple of bugs in the process.
The current version of the module is not able to handle multiple assortments, especially ones that are exclusive (e.g. one assortment with all consumable products and one with all services) and the module seemingly breaks, ignoring the selected rule (e.g. no_show)
With these changes, that behaviour is fixed, and additionally assortments for the same website and partner are merged in a logical OR.