Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] website_sale_checkout_skip_payment: Migration to 18.0 #976

Merged

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_checkout_skip_payment branch from f7f686a to 977a796 Compare October 21, 2024 18:16
@pilarvargas-tecnativa
Copy link
Contributor Author

pilarvargas-tecnativa commented Oct 21, 2024

I have to reduce administrative commits, I know.

@pedrobaeza
Copy link
Member

And check tests

/ocabot migration website_sale_checkout_skip_payment

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 21, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 21, 2024
7 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_checkout_skip_payment branch from 977a796 to ae069c9 Compare October 22, 2024 08:04
chienandalu and others added 23 commits October 22, 2024 10:19
…ut confirmation step when partner is has skip payment flag
Currently translated at 25.0% (2 of 8 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/it/
Currently translated at 87.5% (7 of 8 strings)

Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/es/
Currently translated at 33.3% (5 of 15 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/nl/
Currently translated at 100.0% (15 of 15 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/ca/
Currently translated at 100.0% (15 of 15 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/es/
…ttons

With this changes the 'Process Checkout' button change to 'Confirm' when the partner has selected the option skip_website_checkout_payment. Furthermore, the button text 'Confirm Order' has been changed to 'Confirm'.

TT29736
… user

When the client is a public user we got an error, because the request.session.uid is None and the value of the field checkout_skip_payment is not computed.

As we want to compute this field always,the condition is removed to avoid the possible error.

TT29736
Currently translated at 100.0% (17 of 17 strings)

Translation: e-commerce-14.0/e-commerce-14.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_checkout_skip_payment/es_AR/
…n is not authenticated

[FIX] website_sale_checkout_skip_payment: CacheMiss error when session is not authenticated
Currently translated at 94.1% (16 of 17 strings)

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_checkout_skip_payment/pt/
Currently translated at 11.7% (2 of 17 strings)

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_checkout_skip_payment/it/
Ivorra78 and others added 15 commits October 24, 2024 16:18
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/es/
VAT is required by website_sale_vat_required module

TT44388
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/fr/
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/it/
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/pt_BR/
Currently translated at 100.0% (16 of 16 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/sv/
When an order is confirmed and goes to the path ‘/shop/confirmation’,
the driver method involved is ‘shop_payment_confirmation’ from websitesale.
With the migration, the wrong method was involved as it was a portal
method and its path is ‘/payment/confirmation’, which has nothing to
do with the confirmation of an order.

TT50360
- The default option in the field isn't detected as term to translate.
- Also, in a multilingual site we should provide that message in each
  language.

TT50516
Currently translated at 100.0% (17 of 17 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/it/
Currently translated at 100.0% (17 of 17 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/pt_BR/
Currently translated at 100.0% (17 of 17 strings)

Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/es_AR/
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 18.0-mig-website_sale_checkout_skip_payment branch from 52dff63 to 3ba3e1c Compare October 24, 2024 14:20
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-976-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 28, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-976-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-976-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0c1b037 into OCA:18.0 Oct 28, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2646af1. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-website_sale_checkout_skip_payment branch October 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.