-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] website_sale_require_legal: Migration to version 17.0 #985
[17.0][MIG] website_sale_require_legal: Migration to version 17.0 #985
Conversation
5f1c147
to
fe6ce73
Compare
d18732b
to
09c4966
Compare
…cope This is what the module does now: - Add the posibility to configure legal terms acceptance requirement before saving a new partner. - Log that acceptance as a note in the partner. - Extend upstream's legal requirement before payment and log that acceptance as a note in the sale order. @Tecnativa TT25963
Currently translated at 100.0% (1 of 1 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_require_legal/es/
…page TT41842 The dependency on website_legal_page has been removed because it has been merged into account
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_require_legal/es/
…e_vat_required module TT44388
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_require_legal Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_require_legal/it/
754dc6b
to
134d448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionally, LGTM. Just a minor comment regarding the README and images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is outdated. Could you please update it?
website_sale_require_legal/static/description/payment-enable.png
Outdated
Show resolved
Hide resolved
134d448
to
d41707c
Compare
ping @chienandalu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d41707c
to
0380914
Compare
0380914
to
d72b08d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 54d484e. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT51564
@chienandalu @carlos-lopez-tecnativa please review