Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] website_sale_require_legal: Migration to version 17.0 #985

Merged
merged 25 commits into from
Nov 29, 2024

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Nov 18, 2024

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-website_sale_require_legal branch 6 times, most recently from d18732b to 09c4966 Compare November 21, 2024 08:03
Jairo Llopis and others added 10 commits November 21, 2024 09:10
…cope

This is what the module does now:

- Add the posibility to configure legal terms acceptance requirement before saving a new partner.
- Log that acceptance as a note in the partner.
- Extend upstream's legal requirement before payment and log that acceptance as a note in the sale order.

@Tecnativa TT25963
Currently translated at 100.0% (1 of 1 strings)

Translation: e-commerce-13.0/e-commerce-13.0-website_sale_require_legal
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_require_legal/es/
…page

TT41842

The dependency on website_legal_page has been removed because it has been merged into account
Currently translated at 100.0% (3 of 3 strings)

Translation: e-commerce-15.0/e-commerce-15.0-website_sale_require_legal
Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_require_legal/es/
mymage and others added 2 commits November 21, 2024 09:10
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-website_sale_require_legal branch 2 times, most recently from 754dc6b to 134d448 Compare November 21, 2024 09:07
Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionally, LGTM. Just a minor comment regarding the README and images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is outdated. Could you please update it?

@pilarvargas-tecnativa
Copy link
Contributor Author

ping @chienandalu

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's something with the migration but the metadata message isn't correctly saved:

image

@pilarvargas-tecnativa
Copy link
Contributor Author

I don't know if it's something with the migration but the metadata message isn't correctly saved:

Solved

image

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-985-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4395bcc into OCA:17.0 Nov 29, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 54d484e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-website_sale_require_legal branch November 29, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.