[17.0][FIX] partner_event: handle contacts with mobile field #444
+56
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em230418
force-pushed
the
17.0-partner_event-fix-mobile
branch
from
292f71a to
741cb8a
Compare
I don't know, what it asks from me |
pedrobaeza
changed the title
pedrobaeza
reviewed
Feb 28, 2025
| ) | ||
|
|
There was a problem hiding this comment.
Don't add empty lines inside method, and more if the previous style was this way.
| phone = vals.get("phone") or mobile | ||
| if phone: | ||
| vals["phone"] = phone | ||
|
|
pedrobaeza
approved these changes
Mar 4, 2025
In Odoo event.registration.mobile field does not exist. As result before this commit, if you manually create registration with partner that has "mobile" field set, KeyError will be raised. Notes for future migrations to 19.0+ included.
em230418
force-pushed
the
17.0-partner_event-fix-mobile
branch
from
f2c20f2 to
b6c6b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Odoo event.registration.mobile field does not exist.
As result before this commit, if you manually create registration with partner that has "mobile" field set, KeyError will be raised.
Notes for future migrations to 19.0+ included.