Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] fieldservice_sale: Migration to version 16.0 #1101

Merged
merged 77 commits into from
Jun 13, 2023

Conversation

stefan-tecnativa
Copy link

@stefan-tecnativa stefan-tecnativa commented Jun 12, 2023

cc @Tecnativa TT43608

@pedrobaeza please review!

This PR is a superseed of #1041

osi-scampbell and others added 30 commits June 12, 2023 09:22
[IMP] Remove Duplicate Field
Added ability to link a product with FSM order template and create FSM
orders upon sale order confirmation
Added option to install fieldservice_sale module
Added support for selling recurring orders
Travis
Typo, wrong model relationship
Improved values prepation method for recurring
Updated errors on SO smart button for recurring
- Completed field service orders will now update the qty_delivered field on linked SO line
-  suggestions from reviewer comments
- This change will allow to create an FSM order for each sales order and link it to the delivery order and invoice
- Combine field service template info from sale order lines and add it to field service order
Consumable and Storable product types were not generating field services
- Was not calling super properly and FSM orders on the sale line that were not recurring orders were not being created.
- Delete unused computed field.
brian10048 and others added 11 commits June 12, 2023 10:04
Sale order and sale order line shared similar code.  This simplifies the logic needed to create FSM orders from a sale order while maintaining the same results
Additions made to tests in migration to 15 (5a3201c) do not make sense.  They just call certain methods, but assert nothing after the method call
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/es/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/es_CL/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/es_AR/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
As sales order line link to order is preserved when duplicating a Sales Order,
the FSM Order generation when confirming the sales order is wrongly skipped.
This commit fix it.
Currently translated at 100.0% (29 of 29 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
only if order line display_type not in ('line_section', 'line_note')
@stefan-tecnativa stefan-tecnativa force-pushed the 16.0-mig-fieldservice_sale branch from 478c522 to f9e9234 Compare June 12, 2023 08:13
@pedrobaeza pedrobaeza requested a review from chienandalu June 12, 2023 08:14
@pedrobaeza
Copy link
Member

Please squash last commit into previous one and use Co-Authored-By sentence at the end of the commit message for including yourself and Alexandre Fayolle

Co-Authored-By: Alexandre Fayolle, Stefan Ungureanu

Dependency on migration of fieldservice_account: OCA#1042
Refactoring and fix view errors
Fix view error (obsolete XMLID)
Remove obsolete onchange
Update unit tests
@stefan-tecnativa stefan-tecnativa force-pushed the 16.0-mig-fieldservice_sale branch from f9e9234 to 1735f9c Compare June 12, 2023 10:33
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1101-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza
Copy link
Member

/ocabot migration fieldservice_sale

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 13, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 16, 2023
48 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#963) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1041.
Perhaps you should check that there is no duplicate work.
CC : @epanisset

@OCA-git-bot OCA-git-bot merged commit efe97a5 into OCA:16.0 Jun 13, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ce531b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.