-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] fieldservice_agreement: Migration to 17.0 #1210
Conversation
[UPD] README.rst
[UPD] README.rst
* [IMP] fieldservice_agreement [UPD] README.rst
… move views to agreement module 3. improve location heirarchy name construction
[UPD] README.rst
[UPD] README.rst
[IMP] fieldservice_vehicle_stock
[UPD] Update fieldservice_agreement.pot Added translation using Weblate (Portuguese (Brazil)) Added translation using Weblate (Spanish (Chile)) Translated using Weblate (Spanish (Chile)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es_CL/ Added translation using Weblate (German) Translated using Weblate (German) Currently translated at 6.7% (1 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ Translated using Weblate (German) Currently translated at 26.7% (4 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ Translated using Weblate (German) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ [ADD] Spanish (es) translation Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Spanish) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Added translation using Weblate (Spanish (Argentina)) Translated using Weblate (Spanish (Argentina)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es_AR/
[MIG] Black [MIG] Added more coverage to tests [MIG] Add contract to dependancy Add maintainer Update CONTRIBUTORS.rst add eol
It will be better to properly fix by not using replace I guess
7e0abc0
to
1f97aa3
Compare
1f97aa3
to
ae16354
Compare
Can you take care of this :
Otherwise we're not supporting the same features that were before the migration. |
I did on a new commit |
As we're removing the dependency on `agreement_serviceprofile`, a new glue module is added to keep the same features than before.
fb69f70
to
2dfb703
Compare
9128787
to
8b034c3
Compare
8b034c3
to
4dc8a54
Compare
@imlopes Can you split this pull request and have one for each module? |
agreements = self.env["agreement"].search( | ||
[("fsm_location_id", "=", loc.id)] | ||
) | ||
ids = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreement_ids = agreements.ids
service_profiles = self.env['agreement.serviceprofile'].search(
[('agreement_id', 'in', agreement_ids)]
)
ids = list(set(service_profiles.ids))
Depends on:
agreement:
Adding new
fieldservice_agreement_serviceprofile
(did in a new commit❓ )Removing dependency from
agreement_serviceprofile
onfieldservice_agreement
and adding a new glue module :agreement_serviceprofile: OCA/agreement#39
...