[17.0][ADD] fieldservice_recurring_repair #1250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankinmax
reviewed
Oct 24, 2024
yankinmax
reviewed
Oct 24, 2024
max3903
changed the title
vvrossem
reviewed
Oct 30, 2024
imlopes
force-pushed
the
17.0-add-fieldservice_recurring_repair
branch
from
a6ac238
to
83b5837
Compare
max3903
reviewed
Nov 15, 2024
There was a problem hiding this comment.
@imlopes Can you use the latest logo from fieldservice?
max3903
reviewed
Nov 15, 2024
| equipment, this module allows you to create a recurring work order for several | ||
| equipments. This way, you can create a recurring order for a group of equipments | ||
| and the `fsm.order` will be created for each equipment. | ||
|
|
max3903
reviewed
Nov 15, 2024
| - set the equipment to the one delivered | ||
| 7. click Start | ||
|
|
||
| This will create one `fsm.order` per equipment and one `repair.order` by `fsm.order`. |
There was a problem hiding this comment.
Suggested change
| This will create one `fsm.order` per equipment and one `repair.order` by `fsm.order`. | |
| This will create one `fsm.order` per equipment and one `repair.order` per `fsm.order`. |
max3903
approved these changes
Nov 15, 2024
Comment on lines
+17
to
+22
| orders = self.env["fsm.order"] | ||
| for equipment in self.equipment_ids: | ||
| order_vals = vals.copy() | ||
| order_vals["equipment_id"] = equipment.id | ||
| orders |= self.env["fsm.order"].create(order_vals) | ||
| return orders |
There was a problem hiding this comment.
Suggested change
| orders = self.env["fsm.order"] | |
| for equipment in self.equipment_ids: | |
| order_vals = vals.copy() | |
| order_vals["equipment_id"] = equipment.id | |
| orders |= self.env["fsm.order"].create(order_vals) | |
| return orders | |
| return self.env["fsm.order"].create( | |
| [ | |
| dict(vals, equipment_id=equipment.id) | |
| for equipment in self.equipment_ids | |
| ] | |
| ) |
nitpicking: to create all at once (better for perf)
Comment on lines
+25
to
+29
| return bool( | ||
| self.fsm_order_template_id | ||
| and self.fsm_order_template_id.type_id | ||
| and self.fsm_order_template_id.type_id.internal_type == "repair" | ||
| ) |
There was a problem hiding this comment.
💡 tip: This is exactly the same as:
Suggested change
| return bool( | |
| self.fsm_order_template_id | |
| and self.fsm_order_template_id.type_id | |
| and self.fsm_order_template_id.type_id.internal_type == "repair" | |
| ) | |
| return self.fsm_order_template_id.type_id.internal_type == "repair" |
| order._onchange_template_id() | ||
| else: | ||
| orders = super()._create_order(date) | ||
| orders._onchange_template_id() |
There was a problem hiding this comment.
Suggested change
| orders._onchange_template_id() |
Already done by super, isn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.