Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [REM] fieldservice: unused _get_stage_color method #1280

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

ivantodorovich
Copy link

The field is a non-stored related since a few versions now.
See:

custom_color = fields.Char(related="stage_id.custom_color", string="Stage Color")

This seems to be a dead leftover code.

@OCA-git-bot
Copy link
Contributor

Hi @brian10048, @max3903,
some modules you are maintaining are being modified, check this out!

@ivantodorovich ivantodorovich changed the title [REM] fieldservice: unused _get_stage_color method [17.0] [REM] fieldservice: unused _get_stage_color method Dec 3, 2024
@ivantodorovich ivantodorovich changed the title [17.0] [REM] fieldservice: unused _get_stage_color method [17.0] [REM] fieldservice: unused _get_stage_color method Dec 3, 2024
@max3903 max3903 added this to the 17.0 milestone Dec 4, 2024
@max3903 max3903 self-assigned this Dec 4, 2024
@max3903
Copy link
Member

max3903 commented Dec 4, 2024

@ivantodorovich It may be used on the map view.

@ivantodorovich
Copy link
Author

@ivantodorovich It may be used on the map view.

Which map view? I searched for occurrences on this and many other oca repositories, and didn't find any other usage. But maybe I missed that one?

There are two hints that suggest it isn't used:

  • The api.depends decorator, which makes no sense on a non-computed field method
  • The fact that it's a private method, thus not exposed as rpc

@max3903
Copy link
Member

max3903 commented Dec 4, 2024

@ivantodorovich In fieldservice_geoengine

@ivantodorovich
Copy link
Author

From what I can see, it just reads this:

custom_color = fields.Char(related="stage_id.custom_color", string="Stage Color")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants