Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] fieldservice: Migration to 15.0 #950

Merged
merged 297 commits into from
Oct 6, 2022
Merged

[15.0][MIG] fieldservice: Migration to 15.0 #950

merged 297 commits into from
Oct 6, 2022

Conversation

victoralmau
Copy link
Member

Superseed: #881

Migration to 15.0

Please @cesar-tecnativa and @CarlosRoca13 can you review it?

@Tecnativa TT35713

@victoralmau victoralmau mentioned this pull request Aug 9, 2022
Closed
@Murtaza-OSI
Copy link
Contributor

Superseed: #881

Migration to 15.0

Please @cesar-tecnativa and @CarlosRoca13 can you review it?

@Tecnativa TT35713

@victoralmau Any Reason for Super-seed: PR ?

@victoralmau
Copy link
Member Author

Yes, the contributor has not attended to the changes for 2 months.

@Murtaza-OSI
Copy link
Contributor

Murtaza-OSI commented Aug 9, 2022 •
edited
Loading

Yes, the contributor has not attended to the changes for 2 months.

If there are not then please add log on there PR before you Super-seed PR:
Even I was not unable see any new change after Super-seed in your PR

@pedrobaeza
Copy link
Member

What are you talking about, @Murtaza-OSI ? What is a log? It's clear that if there are comments and they are not attended, the contributor is not maintaining the PR. We have finished the job and respected the attribution, even for the not done changes.

@Murtaza-OSI
Copy link
Contributor

What are you talking about, @Murtaza-OSI ? What is a log? It's clear that if there are comments and they are not attended, the contributor is not maintaining the PR. We have finished the job and respected the attribution, even for the not done changes.

I agree with you but you. But ss i see there is nothing been improved in this PR. So is this correct only make new PR without any improvements? And Super-seed Old PR?

@victoralmau
Copy link
Member Author

I have separated the changes into 2 commits to make it easier to review.

@pedrobaeza
Copy link
Member

@brian10048 @Murtaza-OSI please review

@pedrobaeza
Copy link
Member

/ocabot migration fieldservice

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 9, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 9, 2022
Open
47 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#854) has been updated to reference the current pull request.
however, a previous pull request was referenced : #881.
Perhaps you should check that there is no duplicate work.
CC : @Chanakya-OSI

@pedrobaeza
Copy link
Member

Your commit doesn't have you as author.

@victoralmau victoralmau force-pushed the 15.0-mig-fieldservice branch 2 times, most recently from e45acc6 to bdcfd56 Compare August 9, 2022 12:31
@victoralmau
Copy link
Member Author

Changes done.

@pedrobaeza
Copy link
Member

@Murtaza-OSI @Chanakya-OSI can you review if everything is OK?

brian10048
brian10048 requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@brian10048 brian10048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#881 deleted some basic features and it looks like since that history was kept for this PR that there are still missing features.

fieldservice/views/fsm_person.xml Show resolved Hide resolved
fieldservice/views/fsm_person.xml Show resolved Hide resolved
@brian10048
Copy link
Contributor

@victoralmau Thank you for taking over this migration task. The improvement for the FSM Stage mixin looks great.
I made some comments regarding deleted features from the primary migration PR

@victoralmau
Copy link
Member Author

@victoralmau Thank you for taking over this migration task. The improvement for the FSM Stage mixin looks great. I made some comments regarding deleted features from the primary migration PR

Thanks, changes done.

brian10048
brian10048 requested changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@brian10048 brian10048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoralmau I found a few other minor changes. Sorry for multiple reviews, but I'm trying to be thorough

fieldservice/models/fsm_order.py Show resolved Hide resolved
fieldservice/views/fsm_order.xml Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 15.0-mig-fieldservice branch 2 times, most recently from 0f987a1 to 75a5cbb Compare September 14, 2022 06:49
@victoralmau
Copy link
Member Author

Changes done.

hparfr and others added 14 commits October 5, 2022 17:01
@hparfr @victoralmau
[FIX] fieldservice fix typo in test
038235b 
fieldservice 14.0.1.15.0
@mymage @victoralmau
[14.0][FIX] fieldservice - worker create
60eb50e 
fieldservice 14.0.1.16.0

fieldservice 14.0.1.17.0
@mymage @victoralmau
Translated using Weblate (Italian)
7ff2e51 
Currently translated at 100.0% (575 of 575 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice/it/
@ygol @victoralmau
fix(fieldservice): adapt access to ir.actions.* records
41bd727 
[IMP] update dotfiles
@ygol @victoralmau
fix(fieldservice) address PR remark
05e3a8a
@hparfr @victoralmau
fieldservice: Fix limit issue
a5ddd57 
without this fix
some_partner.child_ids.mapped('fsm_location_id')
return just one rec instead of all the expected records

fieldservice 14.0.1.17.1

[UPD] README.rst

fieldservice 14.0.1.17.2
@francesco-ooops @victoralmau
Translated using Weblate (Italian)
7303205 
Currently translated at 100.0% (575 of 575 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice/it/
@brian10048 @victoralmau
[IMP] fieldservice: Team dashboard
39b2444 
fieldservice 14.0.1.18.0
@paradoxxxzero @victoralmau
[FIX] fieldservice: Add missing calendar view
f666a45 
In fsm.order action : action_fsm_operation_order

fieldservice 14.0.1.18.1
@hparfr @victoralmau
fieldservice: fix Settings link on dashboard
844834c 
And rename Settings to Configuration to be aligned
with Stock and Account

[UPD] Update fieldservice.pot

fieldservice 14.0.1.19.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-14.0/field-service-14.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice/
@hparfr @victoralmau
fieldservice add person_id in orders view
3b213bc
@victoralmau
[14.0][ADD] fieldservice, fix duplicate/copy method
1d549c9 
[UPD] Update fieldservice.pot

fieldservice 14.0.1.19.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-14.0/field-service-14.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice/

fieldservice 14.0.1.20.0
@Freni-OSI @victoralmau
[15.0][FIX] Fixed travis
5b58eed
@Freni-OSI @victoralmau
[15.0][MIG] fieldservice
090eb57
@victoralmau victoralmau force-pushed the 15.0-mig-fieldservice branch 2 times, most recently from ff3e53f to 431741c Compare October 5, 2022 15:18
@oca-clabot
Copy link

Hey @victoralmau, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@victoralmau
Copy link
Member Author

You may also include these two PR: #957 #949

Changes included in commit history.

@victoralmau About the mixin, can you put it in its own commit ? It's hard to distinguish migrations from introduced changes.

I have split the mixin changes into a different commit.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-950-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7b41973 into OCA:15.0 Oct 6, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2162566. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@hparfr hparfr hparfr requested changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@brian10048 brian10048 brian10048 approved these changes

@max3903 max3903 max3903 approved these changes

Assignees

@victoralmau victoralmau

Labels
merged 🎉 migration
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.