-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] hr_employee_birthay_mail: res_users configurable #1267
base: 14.0
Are you sure you want to change the base?
[14.0][FIX] hr_employee_birthay_mail: res_users configurable #1267
Conversation
3fdddda
to
e69160f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR has the |
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
882bf87
to
b227b16
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@dreispt Is it possible to reopoen and merge? I think it is a needed fix for the module. Thank you |
Sure, can you rebase please? |
b227b16
to
c6a8be9
Compare
@dreispt Yes, of course. Done! |
This PR allows each user to grant permission for anniversary notifications from "My profile", otherwise only HR administrators can edit it.
The group "hr.group_hr_user" is also added. Without this group, the open attendances at that time fail and do not allow the attendance session to be closed.
@ForgeFlow