Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][15.0] passport_expiration #1339

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

yankinmax
Copy link

@leemannd
Copy link
Contributor

leemannd commented Apr 3, 2024

Technically the code is good, but we loos the git history. I think this should be respected

@yankinmax
Copy link
Author

@leemannd IDK how to transfer git commit through different submodules. That's why did it such way.

@OpenCode
Copy link

OpenCode commented May 7, 2024

@leemannd IDK how to transfer git commit through different submodules. That's why did it such way.

You can follow this guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

@leemannd
Copy link
Contributor

leemannd commented May 8, 2024

@yankinmax It should work:

@yankinmax
Copy link
Author

@leemannd is ok now?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
@leemannd
Copy link
Contributor

Hello @damdam-s , a review is welcome

@leemannd
Copy link
Contributor

Hello @OCA/human-resources-maintainers a review and merge is welcome

Copy link
Member

@damdam-s damdam-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@Saran440
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1339-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit c6d5737 into OCA:15.0 Sep 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1fb03ad. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants