Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][REM] Removed the possibility to associate additional fee in Payment Mode Boleto #1798

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

mbcosta
Copy link
Contributor

@mbcosta mbcosta commented Feb 7, 2022

Removed the possibility to associate additional fee in payment mode Boleto, this is forbidden in Brazil.

Removida a possibilidade de associar um Produto Taxa/Tarifa a um Modo de Pagamento, como isso estava no modulo que implementa o CNAB e pelo o que vi e entendi isso deixou de ser permitido nos Boletos a partir de 2008 eu estou retirando totalmente essa implementação, mais detalhes em #1793

cc @renatonlima @rvalyi @marcelsavegnago @mileo @felipemotter @netosjb

@mbcosta mbcosta force-pushed the 12.0-REM-additional_taxes_in_boleto branch from 16b5a70 to ce51144 Compare February 7, 2022 14:52
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

menos código = menos bugs. Aprovado!

@rvalyi
Copy link
Member

rvalyi commented Feb 8, 2022

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1798-by-rvalyi-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a508130 into OCA:12.0 Feb 8, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 12aad60. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants