Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][REF] l10n_it_fatturapa_import_zip: Clarify active invoices flow #4454

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][REF] l10n_it_fatturapa_import_zip: Clarify active invoices flow #4454

wants to merge 1 commit into from

Conversation

sergiocorato
Copy link
Contributor

No description provided.

@sergiocorato sergiocorato mentioned this pull request Nov 25, 2024
Open
2 tasks
@sergiocorato sergiocorato linked an issue Nov 25, 2024 that may be closed by this pull request
l10n_it_fatturapa_import_zip: l’importazione del file zip genera soltanto fatture passive #3773
Open
2 tasks
andreampiovesana
andreampiovesana approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francesco-ooops francesco-ooops added 14.0 is porting This pull request is porting a change from another version labels Nov 25, 2024
SirAionTech
SirAionTech requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Vedi i commenti qui sotto

l10n_it_fatturapa_import_zip/readme/CONFIGURE.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 14.0 viene usato il formato .rst (vedi i formati degli altri file in questa cartella), puoi creare anche questo file in quel formato?

Nella PR la CI di pre-commit non solleva errore perché nelle PR non vengono rigenerati i README, vedi l'esecuzione di questa PR: https://github.com/OCA/l10n-italy/actions/runs/12005701551/job/33462795664?pr=4454#step:7:14:

Generate addons README files from fragments.............................Skipped

Infatti, eseguendo pre-commit in locale viene sollevato l'errore

Generate addons README files from fragments..............................Failed

  • hook id: oca-gen-addon-readme
  • exit code: 1

Both .md and .rst fragments found in ./l10n_it_fatturapa_import_zip/readme. Please ensure the same format is used for all fragments.

l10n_it_fatturapa_import_zip/README.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potresti includere anche le modifiche a USAGE? In #3774 ci sono:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech requested changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

Assignees
No one assigned
Labels
14.0 is porting This pull request is porting a change from another version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

l10n_it_fatturapa_import_zip: l’importazione del file zip genera soltanto fatture passive
4 participants
@sergiocorato @andreampiovesana @SirAionTech @francesco-ooops