Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] l10n_es_facturae: Fill InvoiceDescription with plain text #2366

Conversation

ao-landoo
Copy link
Contributor

El campo InvoiceDescription se estaba rellenando directamente con el valor del campo narration, que se trata de un campo tipo html.

Se utiliza la función get_narration() que define el módulo para pasar el contenido del campo a texto mediante html2plaintext

El problema ha sido detectado en el PR #2149

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@ao-landoo ao-landoo changed the title [15.0][FIX] l10n_es_facturae: Fill InvoiceDescription with plan text [15.0][FIX] l10n_es_facturae: Fill InvoiceDescription with plain text Jun 20, 2022
@ao-landoo ao-landoo force-pushed the 15.0-fix-l10n_es_facturae-parse_invoice_description_2_plain_text branch from 9830027 to 5d89bd8 Compare June 20, 2022 10:56
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por mi bien, pero fallan los tests

@ao-landoo ao-landoo force-pushed the 15.0-fix-l10n_es_facturae-parse_invoice_description_2_plain_text branch 3 times, most recently from 4fc0134 to 335a3ce Compare June 28, 2022 08:08
@ao-landoo ao-landoo force-pushed the 15.0-fix-l10n_es_facturae-parse_invoice_description_2_plain_text branch from 335a3ce to 11ce885 Compare July 1, 2022 11:08
@ao-landoo
Copy link
Contributor Author

@pedrobaeza Se puede mergear?

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jul 1, 2022
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2366-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d6ac4f2 into OCA:15.0 Jul 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ddfb4fb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants