Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mis_builder: let non-admins print reports #476

Closed
wants to merge 2 commits into from

Conversation

yajo
Copy link
Member

@yajo yajo commented Nov 9, 2022

Description

Before this patch, normal users would get AccessError when trying to preview or print reports.

Towards #415.

@moduon MT-1527

@yajo
Copy link
Member Author

yajo commented Nov 9, 2022

No CI here? @sbidoul

@sbidoul
Copy link
Member

sbidoul commented Nov 9, 2022

Dunno why there is no ci, no time to look today.
BTW, I had started this back then #416

@yajo
Copy link
Member Author

yajo commented Nov 9, 2022

Yikes, I didn't find it :/. Well, this one includes a smaller change, changelog a test. Maybe you can merge and rebase yours on top of this one? Or how do you prefer to proceed?

@sbidoul
Copy link
Member

sbidoul commented Nov 9, 2022

I'll rebase mine. This looks good to me. Thanks for adding a test.

@yajo yajo force-pushed the 15.0-mis_builder-fix_access_error branch from 145cf6a to bb82b0a Compare November 14, 2022 11:55
yajo added 2 commits November 14, 2022 12:51
Normal users get `AccessError` when trying to preview or print reports.

Tests OCA#415.

@moduon MT-1527
Normal users now don't get `AccessError` when trying to preview or print reports.

Fixes OCA#415.

@moduon MT-1527
@yajo
Copy link
Member Author

yajo commented Nov 14, 2022

This is weird. Locally, both pre-commit and odoo tests pass OK. Also in production you can open the mis report. Some ideas? Maybe you can merge this on #416 and continue there?

I rebased, just in case.

@yajo yajo force-pushed the 15.0-mis_builder-fix_access_error branch from bb82b0a to d43fe2c Compare November 14, 2022 12:55
@sbidoul
Copy link
Member

sbidoul commented Nov 14, 2022

I just pushed a copier update to 15.0 here. A rebase should fix pre-commit.
Regarding the test failure it looks like it's the new test failing?

@yajo
Copy link
Member Author

yajo commented Nov 14, 2022

The pre-commit failure is new; must be python 3.11 kicking in.

Regarding the test, yes it's the one that's failing. But since your fix in #416 is better, that's why I think maybe it's a good moment for you to merge it. Probably the test will be OK in #416.

@sbidoul
Copy link
Member

sbidoul commented Nov 14, 2022

Ok, cherry-picked in #416. So closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants