[IMP] mis_builder: provide more views in drilldown #587
Conversation
|
Hi @sbidoul, |
IT-Ideas
force-pushed
the
16.0-mis-builder-provide_more_views_in_drilldown-lst
branch
from
d8d61f6 to
fee954f
Compare
| def _get_drilldown_model_views(self): | ||
| self.ensure_one() | ||
| types = self.env["ir.ui.view"]._read_group( | ||
| [("model", "=", self.source_aml_model_name)], ["type"], ["type"] |
There was a problem hiding this comment.
Can you make _get_drilldown_model_views a model method, and pass the model name as argument?
Because in the drilldown method, we use period.source.aml_model_name.
Can you also add a little unit test for _get_drilldown_model_views?
Prior to this commit only the `tree` and `form` views where made available while drilldowning in the `mis.report.instance` preview. After this commit if available, the `tree`, `form`, `pivot` and `chart` views will be provided. The available views and orders can be easilly overriden.
IT-Ideas
force-pushed
the
16.0-mis-builder-provide_more_views_in_drilldown-lst
branch
from
fee954f to
75706b2
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sbidoul
removed
the
stale
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 312f574. Thanks a lot for contributing to OCA. ❤️ |
Prior to this commit only the
treeandformviews where made available while drilldowning in themis.report.instancepreview.After this commit if available, the
tree,form,pivotandchartviews will be provided.The available views and orders can be easilly overriden.
Thanks for your pull request. Please take a moment to review if it meets the following
guidelines.