Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] __manifest__.py with version 16->17 #594

Closed
wants to merge 1 commit into from

Conversation

andreampiovesana
Copy link

error version 16 -> 17

Thanks for your pull request. Please take a moment to review if it meets the following
guidelines.

Description

Before coding, it is recommended to create an issue to discuss the problem or feature
you want to add. If you did not, don't worry, we can discuss on the PR too.

If there is a pre-existing issue that your PR implements or fixes, add a pointer to it
in the PR description.

If your PR is simple enough that it does not require a preliminary discussion, then make
sure to explain what it does (i.e. why the change is necessary).

Test

Don't forget to add unit tests. If your PR fixes a bug, prefer creating a separate
commit for the test so we one see that your test reproduces the bug and is fixed by the
PR.

Target branch

MIS Builder is actively maintained for Odoo versions 9, 10, 11 and 12.

If your feature is applicable with the same implementation to all these versions, please
target branch 10.0. Maintainers will port it to 9, 11 and 12 soon after merging.

In the rare cases your feature or implementation is specific to an Odoo version, then
target the corresponding branch.

CLA

Have you signed the OCA Contributor License Agreement? If not, please visit
https://odoo-community.org/page/cla to learn how.

Changelog entry

This projects uses towncrier to generate it's
changelog. Make sure your PR includes a changelog entry in
<addon>/readme/newsfragments/. It must have the issue or PR number as name, and one of
.feature, .bugfix, .doc (for documentation improvements), .misc (if a ticket has
been closed, but it is not of interest to users). The changelog entry must be reasonably
short and phrased in a way that is understandable by end users.

Documentation

Consider improving the documention in docs/.

error version 16 -> 17
@zamberjo
Copy link
Member

zamberjo commented Jan 25, 2024

It is true that it gives an error because it expects {serial}.x.y.z being serial 17.0. And being the version of 16.0 gives error and does not start odoo if you add this repository to the addons_path.

But, the issue is that this module has not been migrated yet.

You can see the progress at #582

@andreampiovesana
Copy link
Author

fix please

@sbidoul
Copy link
Member

sbidoul commented Feb 7, 2024

The 17.0 branch is not ready to use. The error with uninstallable modules with an incorrect version in the addons path is an Odoo bug: odoo/odoo#141747.

@micheledic
Copy link

the error is a blocking error , the merge is urgent!

micheledic

This comment was marked as outdated.

Copy link

@micheledic micheledic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change to 17.0.1.0.0

@sbidoul
Copy link
Member

sbidoul commented Mar 19, 2024

The upstream fix for uninstallable addons has been merged (odoo/odoo#157657). So closing this.

@sbidoul sbidoul closed this Mar 19, 2024
@micheledic
Copy link

The upstream fix for uninstallable addons has been merged (odoo/odoo#157657). So closing this.

Sorry but this PR Is neeeded because the module Is Correctly migrated to 17.0 but they forgotten to change manifest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants