[16.0][FIX] mis_builder: use compute_sudo on field source_aml_model_id to prevent errors due to missing permissions.

[JordiBForgeFlow]

The field source_aml_model_id refers to the ir.model, which is a technical in nature, and users should not have naturally permission to read them directly.

Test => PENDING

Don't forget to add unit tests. If your PR fixes a bug, prefer creating a separate
commit for the test so we one see that your test reproduces the bug and is fixed by the
PR.

Target branch => PENDING TO CHECK IF PREVIOUS BRANCHES ARE AFFECTED

MIS Builder is actively maintained for Odoo versions 9, 10, 11 and 12.

If your feature is applicable with the same implementation to all these versions, please
target branch 10.0. Maintainers will port it to 9, 11 and 12 soon after merging.

In the rare cases your feature or implementation is specific to an Odoo version, then
target the corresponding branch.

Changelog entry => DONE

[OCA-git-bot]

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

[sbidoul]

Hi @JordiBForgeFlow. Sounds good but normally compute_sudo is true by default for stored computed fields: https://github.com/odoo/odoo/blame/60ee2dc2601c1fe7440d69d01844cc7eca4d39df/odoo/fields.py#L448

So I'm curious about the circumstances that trigger a problem related to this.

[JordiBForgeFlow]

@sbidoul hmm good point. It failed in two different environments... will check further.

[JordiBForgeFlow]

@sbidoul I reproduced the error in runboat:
https://github.com/OCA/mis-builder/assets/7683926/11e46b88-e90e-4a0f-a82c-f8ce3db5d5a5

[JordiBForgeFlow]

The field is certainly compute_sudo = True

[JordiBForgeFlow]

When I add compute_sudo explicity in the field definition, the error does not appear. It's a mistery! Perhaps @MiquelRForgeFlow , the master mistery solver, can help here...

[MiquelRForgeFlow]

The problem was not in the compute, but in the _check_source_aml_model_id contraint, when accessing technical field field_id. Fixed.

[sbidoul]

Suggested change

	The user may not have permission to access to the field field_id in ir.model, which corresponds to an ir.model.fields record.
	It's a technical issue in nature, so we should use sudo to access it without error.
	Resolve a permission issue when creating report periods with a user without admin rights.

Let's have a user friendly change log.

[MiquelRForgeFlow]

Done

[sbidoul]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-596-by-sbidoul-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 25d65be. Thanks a lot for contributing to OCA. ❤️

[JordiBForgeFlow]

Thanks @sbidoul !