Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] mis_builder: add option on report instance to drilldown in popup #621

Draft
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

AnizR
Copy link
Contributor

@AnizR AnizR commented Aug 7, 2024

When drilling down on a cell inside a report, open it in a new pop-up window instead of current window to avoid reloading the report when going back.

It is customizable on each report instance:
image

@AnizR AnizR force-pushed the mis-builder-drilldown branch from 111837f to 6c48d7e Compare August 7, 2024 10:29
@sbidoul
Copy link
Member

sbidoul commented Aug 7, 2024

Let's add this to the core module, with a Popup drilldown option.

@AnizR AnizR force-pushed the mis-builder-drilldown branch 2 times, most recently from 660a144 to f5885d8 Compare August 22, 2024 08:23
@AnizR AnizR changed the title [16.0][ADD] mis_builder_drilldown_new_window: init [16.0][ADD] mis_builder: add option on report instance to drilldown in pop Aug 22, 2024
@AnizR AnizR force-pushed the mis-builder-drilldown branch from f5885d8 to 5c4e7d7 Compare August 22, 2024 08:25
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul sbidoul marked this pull request as draft September 11, 2024 10:10
@sbidoul
Copy link
Member

sbidoul commented Sep 11, 2024

Setting to draft. The popup only partially solves the original issue, which is the recomputation time when navigating back to the report after drilldown. Moreover the ergnomics of the popup is not optimal as a typical move lines tree view does not fit nicely in the popup.

@sbidoul sbidoul mentioned this pull request Sep 11, 2024
@sbidoul
Copy link
Member

sbidoul commented Sep 11, 2024

We could consider #633 instead

@sbidoul sbidoul changed the title [16.0][ADD] mis_builder: add option on report instance to drilldown in pop [16.0][ADD] mis_builder: add option on report instance to drilldown in popup Nov 11, 2024
@sbidoul sbidoul added the 16.0 label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants