Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] mis_builder: add support for branch companies #646

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[17.0][IMP] mis_builder: add support for branch companies #646

merged 3 commits into from
Nov 11, 2024

Conversation

jguenat
Copy link
Member

@jguenat jguenat commented Nov 8, 2024

Attempt to fix #645

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

sbidoul
sbidoul reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought we'd need this for 18 only. The fix looks good to me.

Could you look at adding a test, probably in test_aep.py ?

mis_builder/models/aep.py Show resolved Hide resolved
@sbidoul sbidoul force-pushed the 17.0-fix-branch-matrix branch from 49b34f0 to 9d91e3b Compare November 11, 2024 10:05
@sbidoul sbidoul changed the title [17.0][FIX] mis_builder: branche and matrix value computation [17.0][IMP] mis_builder: add support for branch companies Nov 11, 2024
@sbidoul sbidoul force-pushed the 17.0-fix-branch-matrix branch from 5927ec2 to 794de74 Compare November 11, 2024 10:12
@sbidoul sbidoul marked this pull request as ready for review November 11, 2024 10:13
sbidoul
sbidoul approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test!

@sbidoul
Copy link
Member

sbidoul commented Nov 11, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-646-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 64b5ea8 into OCA:17.0 Nov 11, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4d06a94. Thanks a lot for contributing to OCA. ❤️

@sbidoul
Copy link
Member

sbidoul commented Dec 11, 2024

Removing the needs port label as this is included in #652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
17.0 enhancement merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with branches on report matrix
3 participants
@jguenat @OCA-git-bot @sbidoul