add some notes about pinning python dependencies in CONTRIBUTING.rst #198
Conversation
|
Thanks, I have update as requested |
|
@rvalyi @pedrobaeza can you please review your requests of changes ? |
|
|
||
| If the module dependencies versions are pinned or if bounds are too stricts, then integrators may face a "dependency hell" with unresolvable dependency conflicts. | ||
|
|
||
| Note that versions in Odoo's requirement.txt are a recommendation (known good versions used in some Debian and/or Ubuntu versions), but Odoo may work well with more recent versions of many libraries, and it frequently happens that one needs to use more recent versions of the Odoo requirements to be compatible with other modern libraries. |
There was a problem hiding this comment.
I wouldn't say "it frequently happens that one needs to use more recent versions of the Odoo requirements to be compatible".
While it's possible, I think it should be a not-so-frequently case and we should stick to the pinned versions as much as possible.
There was a problem hiding this comment.
we should stick to the pinned versions as much as possible.
Wow; I had the feeling there was shared agreement on this.
There was a problem hiding this comment.
Well, I already said in #198 (comment) that we shouldn't advise the use of latest versions.
There was a problem hiding this comment.
what about "it may happen" instead of "frequently happens" so it looks more neutral. frequently is a bit subjective and depends also about the point of view like: it might be frequent for us developpers who specialize into delivering cutting edge technologies but it's probably not so frequent for the average OCA module user who will like something easy to install that just work out of the box with the standard Odoo dependencies.
There was a problem hiding this comment.
It's not an advice to use lastest version, it's about to not pin version without a good reason in oca.
I will %s/frequently/may as suggested by @rvalyi to be more neutral.
Again, the recommandation here, in this paragraph, is not about use modern or outdated dependencies.
There was a problem hiding this comment.
Thanks, I like @rvalyi suggestion.
Add some notes about pinning python dependencies. Taken from sbidoul : OCA/queue#530 (comment)
slighly edited from @sbidoul comment : OCA/queue#530 (comment)