[15.0][IMP] payroll_account: allow other modules to influence the values of the journal items #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nimarosa, @appstogrow, |
AaronHForgeFlow
force-pushed
the
15.0-imp-payroll_account-hooks
branch
from
6add6fd to
390e2cb
Compare
|
pre-commit will pass when #147 is merged |
AaronHForgeFlow
force-pushed
the
15.0-imp-payroll_account-hooks
branch
from
390e2cb to
58d0511
Compare
Make action_payslip_done by adding prepare methods. This allows third modules to introduce changes in the journal items. Introducing changes may be necessary in case the third module adds a mandatory field that is not filled in.
AaronHForgeFlow
force-pushed
the
15.0-imp-payroll_account-hooks
branch
from
58d0511 to
00bec4a
Compare
nimarosa
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Changes looks good. Functionality tested in runboat and seems okay.
@AaronHForgeFlow Can you port this PR when merged to v16.0 too? That way we maintain this improvement in future versions.
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 1906e5d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify action_payslip_done by adding prepare methods. This allows third modules to introduce changes in the journal items. Introducing changes may be necessary in case the third module adds a mandatory field that is not filled in, for example, the account_operating_unit module adds the operating unit as mandatory in the journal item.
cc @ForgeFlow