Skip to content

Commit

Permalink
[IMP] pos_partner_firstname: Black, isort, prettier
Browse files Browse the repository at this point in the history
  • Loading branch information
etobella committed Jan 10, 2024
1 parent c07a188 commit b951f8c
Show file tree
Hide file tree
Showing 9 changed files with 84 additions and 43 deletions.
51 changes: 32 additions & 19 deletions pos_partner_firstname/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,20 @@ POS Partner Firstname
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github
:target: https://github.com/OCA/pos/tree/16.0/pos_partner_firstname
:target: https://github.com/OCA/pos/tree/17.0/pos_partner_firstname
:alt: OCA/pos
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_firstname
:target: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_partner_firstname
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/pos&target_branch=16.0
:target: https://runboat.odoo-community.org/builds?repo=OCA/pos&target_branch=17.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

The module adds the support of the fields of the partner_firstname module within the point of sale interface,
allowing to view and edit them in the given customer view.
The module adds the support of the fields of the partner_firstname
module within the point of sale interface, allowing to view and edit
them in the given customer view.

**Table of contents**

Expand All @@ -41,40 +42,52 @@ Known issues / Roadmap

Some features we would need to cover in the future:

* When the field ``name`` is set to be readonly the module must prevent the field to have red border and the possibility to have the cursor, and change the background color of the name field could be user friendly.
* In back office, the name *OR* the surname is mandatory. In front office, the name *AND* the surname is mandatory. Should be great to have a similar behaviour.
* In back office, default is "company". In front office, default is "individual". The behaviour should however depend by *B2B* or *B2C* setting in order to set the right default.
* In individual mode, in back office, it is possible to select the parent company. In individual mode, in front office, it is not possible. However we would also have to say that odoo doesn't permit the parent company selection.

The ticket referencing the above information can be read at https://github.com/OCA/pos/pull/775
- When the field ``name`` is set to be readonly the module must prevent
the field to have red border and the possibility to have the cursor,
and change the background color of the name field could be user
friendly.
- In back office, the name *OR* the surname is mandatory. In front
office, the name *AND* the surname is mandatory. Should be great to
have a similar behaviour.
- In back office, default is "company". In front office, default is
"individual". The behaviour should however depend by *B2B* or *B2C*
setting in order to set the right default.
- In individual mode, in back office, it is possible to select the
parent company. In individual mode, in front office, it is not
possible. However we would also have to say that odoo doesn't permit
the parent company selection.

The ticket referencing the above information can be read at
`https://github.com/OCA/pos/pull/775 <https://github.com/OCA/pos/pull/775>`__

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/pos/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_firstname%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_firstname%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~
-------

* Roberto Fichera

Contributors
~~~~~~~~~~~~
------------

* Roberto Fichera <[email protected]>
* Lorenzo Battistini (https://takobi.online)
* Dhara Solanki <[email protected]>
- Roberto Fichera <[email protected]>
- Lorenzo Battistini
(`https://takobi.online <https://takobi.online>`__)
- Dhara Solanki <[email protected]>

Maintainers
~~~~~~~~~~~
-----------

This module is maintained by the OCA.

Expand All @@ -94,6 +107,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:

|maintainer-robyf70|

This module is part of the `OCA/pos <https://github.com/OCA/pos/tree/16.0/pos_partner_firstname>`_ project on GitHub.
This module is part of the `OCA/pos <https://github.com/OCA/pos/tree/17.0/pos_partner_firstname>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
3 changes: 3 additions & 0 deletions pos_partner_firstname/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["whool"]
build-backend = "whool.buildapi"
3 changes: 3 additions & 0 deletions pos_partner_firstname/readme/CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Roberto Fichera \<<[email protected]>\>
- Lorenzo Battistini (<https://takobi.online>)
- Dhara Solanki \<<[email protected]>\>
3 changes: 0 additions & 3 deletions pos_partner_firstname/readme/CONTRIBUTORS.rst

This file was deleted.

3 changes: 3 additions & 0 deletions pos_partner_firstname/readme/DESCRIPTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The module adds the support of the fields of the partner\_firstname
module within the point of sale interface, allowing to view and edit
them in the given customer view.
2 changes: 0 additions & 2 deletions pos_partner_firstname/readme/DESCRIPTION.rst

This file was deleted.

19 changes: 19 additions & 0 deletions pos_partner_firstname/readme/ROADMAP.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
Some features we would need to cover in the future:

- When the field `name` is set to be readonly the module must prevent
the field to have red border and the possibility to have the cursor,
and change the background color of the name field could be user
friendly.
- In back office, the name *OR* the surname is mandatory. In front
office, the name *AND* the surname is mandatory. Should be great to
have a similar behaviour.
- In back office, default is "company". In front office, default is
"individual". The behaviour should however depend by *B2B* or *B2C*
setting in order to set the right default.
- In individual mode, in back office, it is possible to select the
parent company. In individual mode, in front office, it is not
possible. However we would also have to say that odoo doesn't permit
the parent company selection.

The ticket referencing the above information can be read at
<https://github.com/OCA/pos/pull/775>
8 changes: 0 additions & 8 deletions pos_partner_firstname/readme/ROADMAP.rst

This file was deleted.

35 changes: 24 additions & 11 deletions pos_partner_firstname/static/description/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -369,9 +369,10 @@ <h1 class="title">POS Partner Firstname</h1>
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:633d10768c33bb428db1bb5ac7e8a6780c007b13be149e52c889338febb7ec0b
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/pos/tree/16.0/pos_partner_firstname"><img alt="OCA/pos" src="https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_firstname"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/pos&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>The module adds the support of the fields of the partner_firstname module within the point of sale interface,
allowing to view and edit them in the given customer view.</p>
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/pos/tree/17.0/pos_partner_firstname"><img alt="OCA/pos" src="https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_partner_firstname"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/pos&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>The module adds the support of the fields of the partner_firstname
module within the point of sale interface, allowing to view and edit
them in the given customer view.</p>
<p><strong>Table of contents</strong></p>
<div class="contents local topic" id="contents">
<ul class="simple">
Expand All @@ -389,19 +390,30 @@ <h1 class="title">POS Partner Firstname</h1>
<h1><a class="toc-backref" href="#toc-entry-1">Known issues / Roadmap</a></h1>
<p>Some features we would need to cover in the future:</p>
<ul class="simple">
<li>When the field <tt class="docutils literal">name</tt> is set to be readonly the module must prevent the field to have red border and the possibility to have the cursor, and change the background color of the name field could be user friendly.</li>
<li>In back office, the name <em>OR</em> the surname is mandatory. In front office, the name <em>AND</em> the surname is mandatory. Should be great to have a similar behaviour.</li>
<li>In back office, default is “company”. In front office, default is “individual”. The behaviour should however depend by <em>B2B</em> or <em>B2C</em> setting in order to set the right default.</li>
<li>In individual mode, in back office, it is possible to select the parent company. In individual mode, in front office, it is not possible. However we would also have to say that odoo doesn’t permit the parent company selection.</li>
<li>When the field <tt class="docutils literal">name</tt> is set to be readonly the module must prevent
the field to have red border and the possibility to have the cursor,
and change the background color of the name field could be user
friendly.</li>
<li>In back office, the name <em>OR</em> the surname is mandatory. In front
office, the name <em>AND</em> the surname is mandatory. Should be great to
have a similar behaviour.</li>
<li>In back office, default is “company”. In front office, default is
“individual”. The behaviour should however depend by <em>B2B</em> or <em>B2C</em>
setting in order to set the right default.</li>
<li>In individual mode, in back office, it is possible to select the
parent company. In individual mode, in front office, it is not
possible. However we would also have to say that odoo doesn’t permit
the parent company selection.</li>
</ul>
<p>The ticket referencing the above information can be read at <a class="reference external" href="https://github.com/OCA/pos/pull/775">https://github.com/OCA/pos/pull/775</a></p>
<p>The ticket referencing the above information can be read at
<a class="reference external" href="https://github.com/OCA/pos/pull/775">https://github.com/OCA/pos/pull/775</a></p>
</div>
<div class="section" id="bug-tracker">
<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/pos/issues">GitHub Issues</a>.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_firstname%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<a class="reference external" href="https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_firstname%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<p>Do not contact contributors directly about support or help with technical issues.</p>
</div>
<div class="section" id="credits">
Expand All @@ -416,7 +428,8 @@ <h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
<ul class="simple">
<li>Roberto Fichera &lt;<a class="reference external" href="mailto:roberto.fichera&#64;levelprime.com">roberto.fichera&#64;levelprime.com</a>&gt;</li>
<li>Lorenzo Battistini (<a class="reference external" href="https://takobi.online">https://takobi.online</a>)</li>
<li>Lorenzo Battistini
(<a class="reference external" href="https://takobi.online">https://takobi.online</a>)</li>
<li>Dhara Solanki &lt;<a class="reference external" href="mailto:dhara.solanki&#64;initos.com">dhara.solanki&#64;initos.com</a>&gt;</li>
</ul>
</div>
Expand All @@ -429,7 +442,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
promote its widespread use.</p>
<p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
<p><a class="reference external image-reference" href="https://github.com/robyf70"><img alt="robyf70" src="https://github.com/robyf70.png?size=40px" /></a></p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/pos/tree/16.0/pos_partner_firstname">OCA/pos</a> project on GitHub.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/pos/tree/17.0/pos_partner_firstname">OCA/pos</a> project on GitHub.</p>
<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
</div>
</div>
Expand Down

0 comments on commit b951f8c

Please sign in to comment.