[16.0][FIX] pos_order_to_sale_order: recompute taxes #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @legalsylvain, |
|
hi @danielduqma you can rebase to have green CI. |
danielduqma
force-pushed
the
16.0-fix-pos_order_to_sale_order-taxes-mapping
branch
from
5f3da08 to
934f79d
Compare
Recompute `sale.order` taxes, as received ones are the ones from product, without fiscal position mapping applied.
danielduqma
force-pushed
the
16.0-fix-pos_order_to_sale_order-taxes-mapping
branch
from
934f79d to
5f81300
Compare
danielduqma
changed the title
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at df170b5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recompute
sale.ordertaxes, as received ones are the ones from product, without fiscal position mapping applied. Follows #1291How to reproduce in branch 16.0:
sale.orderhas different taxes and totalsWith this change, taxes are recomputed right after sale order creation, so taxes are the same as in PoS:
cc @legalsylvain @Jordi-Buitrago @navarrorico
FL-556-5334