Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] product_dimension #1168

Merged
merged 50 commits into from
Nov 22, 2022
Merged

Conversation

FrancoMaxime
Copy link
Member

lepistone and others added 30 commits October 11, 2022 11:03
osv -> orm

test computation of volume in same UOM

add test with conversion from cm

refactor, new API, generic UOM computation

fix wording in readme

do not use camelcase for Models

put dimensions in their own group

Otherwise they are shown as weights.

fill in placeholders in README

README is actually rst, not md

use a new-api onchange, update tests, refactor

Also, spell "height" correctly.
REF remove executable permission

ADD missing tag images

Conflicts:
	product_dimension/__openerp__.py
FIX remove oldname in field height

ADD onchange calculate volume on product template
[MIG] Make modules uninstallable

[MIG] Rename manifest files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/
Currently translated at 100.0% (8 of 8 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/
Currently translated at 100.0% (11 of 11 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/pt/
@oca-clabot
Copy link

Hey @FrancoMaxime, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

Copy link
Contributor

@emagdalenaC2i emagdalenaC2i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a little comment about the History.rst file

product_dimension/readme/HISTORY.rst Show resolved Hide resolved
@rousseldenis
Copy link
Contributor

/ocabot migration product_dimension

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 7, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 7, 2022
60 tasks
@FrancoMaxime FrancoMaxime force-pushed the 16.0-mig-product_dimension branch from 5a6bcc6 to 36a5f6a Compare November 8, 2022 07:11
@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1168-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 81d2a3e into OCA:16.0 Nov 22, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f990d97. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet