-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] product_code_mandatory #1693
[16.0][MIG] product_code_mandatory #1693
Conversation
* [ADD] Module to set the internal reference of the product as required.
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_code_mandatory/pt/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr_FR/
Currently translated at 100.0% (2 of 2 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/it/
/ocabot migration product_code_mandatory |
The migration issue (#1157) has not been updated to reference the current pull request because a previous pull request (#1575) is not closed. |
/ocabot migration product_code_mandatory |
86ecd16
to
5946343
Compare
65e808b
to
8c035c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, working ok. The internal reference is automatically fulfilled for the products and variants if it is empty.
@pedrobaeza Hi Pedro, Same case in this pr, i think we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration commit contains changes that don't belong here, and the second commit, if they are migration reviews, should be squashed into the migration commit.
8c035c7
to
0380300
Compare
@pedrobaeza |
Move setUp test class to setUpClass for better performant [ADD] product_code_mandatory: Add contributors
0380300
to
8cad0d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 749acae. Thanks a lot for contributing to OCA. ❤️ |
Last PR closed for the migration module: #1575.
The closed PR included changes that were incorporated and improved in this PR.
Also please find the mig pr to v17 #1697