Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.0 migration printer zpl2 #362

Open
wants to merge 71 commits into
base: 17.0
Choose a base branch
from

Conversation

MarcLSubteno
Copy link

@MarcLSubteno MarcLSubteno commented Aug 8, 2024

Fix pre-commit error on #347

@MarcLSubteno MarcLSubteno force-pushed the 17.0-migration-printer_zpl2 branch from 3986218 to 9fe55e4 Compare August 8, 2024 12:55
<field name="printer_id" />
<field
name="label_id"
context="{'default_model_id': active_model_id}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this domain="[('model_id', '=', active_model_id)]" to the label_id field because I tested this pull request on my localhost and encountered a problem: the label_id field is always empty, even though I have set a label for the current model. This is happening because the current context doesn't have active_model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aminambk
Seems like @MarcLSubteno did the change.
Could you please re-review and resolve this?

@MarcLSubteno MarcLSubteno force-pushed the 17.0-migration-printer_zpl2 branch from 9fe55e4 to 0159854 Compare August 21, 2024 13:43
@aminambk
Copy link

@MarcLSubteno

Hello,
There is an error when trying to update printers from CUPS

image

@micheledic
Copy link

micheledic commented Oct 7, 2024

Can you cherry pick #343 ?

@MarcLSubteno MarcLSubteno force-pushed the 17.0-migration-printer_zpl2 branch from 0159854 to f0d05a8 Compare October 9, 2024 10:55
@gaikaz
Copy link
Member

gaikaz commented Oct 30, 2024

@micheledic
Seems like your suggested PR was cherry-picked.
Could you give another look and maybe approve?

Copy link
Member

@gaikaz gaikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.
Functionally installs, but haven't had a chance to test.

@gaikaz
Copy link
Member

gaikaz commented Dec 4, 2024

@OCA/reporting-engine-maintainers
I hate pinging like this, but I suppose you guys are the ones to approve and merge this.
Could we please get a review here? 🙏🏻

@etobella
Copy link
Member

etobella commented Dec 4, 2024

Well, tests and pre-commit are failing. I will do a rebase and see if it is solved, otherwise, we will need some actions from the author.

/ocabot rebase

pedrobaeza and others added 21 commits December 4, 2024 17:45
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: report-print-send-15.0/report-print-send-15.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-15-0/report-print-send-15-0-printer_zpl2/
Currently translated at 6.0% (12 of 200 strings)

Translation: report-print-send-15.0/report-print-send-15.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-15-0/report-print-send-15-0-printer_zpl2/it/
Currently translated at 6.0% (12 of 200 strings)

Translation: report-print-send-15.0/report-print-send-15.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-15-0/report-print-send-15-0-printer_zpl2/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/
Currently translated at 100.0% (200 of 200 strings)

Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/
Currently translated at 81.5% (163 of 200 strings)

Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/it/
Currently translated at 100.0% (200 of 200 strings)

Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2
Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/it/
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 17.0.

@OCA-git-bot OCA-git-bot force-pushed the 17.0-migration-printer_zpl2 branch from f0d05a8 to 12feecc Compare December 4, 2024 17:45
@gaikaz
Copy link
Member

gaikaz commented Dec 12, 2024

@MarcLSubteno
Could you please look at the failed test and fix them?

@MarcLSubteno MarcLSubteno force-pushed the 17.0-migration-printer_zpl2 branch from 12feecc to dd7794b Compare December 12, 2024 14:32
@micheledic
Copy link

any news about to merge ?

@etobella
Copy link
Member

Removing tests shouldn't be an option @MarcLSubteno

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore the tests please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.