Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] sale_loyalty_order_line_link: Fix to avoid recursion error and test improvements #158

Merged

Conversation

pilarvargas-tecnativa
Copy link
Contributor

cc @Tecnativa TT44349

@chienandalu @stefan-tecnativa please review

@OCA-git-bot
Copy link
Contributor

Hi @chienandalu,
some modules you are maintaining are being modified, check this out!

@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review October 4, 2023 09:29
Copy link
Contributor

@stefan-tecnativa stefan-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot. The error isn't anymore.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 6, 2023
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-158-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4d399c0 into OCA:16.0 Oct 6, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 831a1d2. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-sale_coupon_order_line_link branch October 6, 2023 14:07
ernesto-garcia-tecnativa pushed a commit to Tecnativa/sale-promotion that referenced this pull request Oct 9, 2023
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants