Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] sale_loyalty_order_suggestion_multi_product: New module #199

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] sale_loyalty_order_suggestion_multi_product: New module #199

wants to merge 1 commit into from

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Jan 29, 2024 •
edited by pedrobaeza
Loading

chienandalu
chienandalu reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the dependencies commit when you're ready :)

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch 2 times, most recently from 9396511 to 1614e38 Compare January 31, 2024 09:11
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review January 31, 2024 09:12
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch from 1614e38 to b9375d1 Compare January 31, 2024 09:21
@pilarvargas-tecnativa
Copy link
Contributor Author

Functionally I do not detect errors in principle. Locally no replication of test errors.

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch 4 times, most recently from 436b614 to 60560a1 Compare February 15, 2024 11:52
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch 2 times, most recently from 4739d78 to 89471d7 Compare February 28, 2024 06:58
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch 5 times, most recently from 003801c to 621683c Compare March 20, 2024 09:40
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch from 621683c to 932c7fd Compare April 25, 2024 10:18
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 12, 2024
@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Jul 15, 2024
Open
1 task
@pilarvargas-tecnativa pilarvargas-tecnativa changed the title [ADD] sale_loyalty_order_suggestion_multi_product: New module [16.0][ADD] sale_loyalty_order_suggestion_multi_product: New module Jul 15, 2024
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch from 932c7fd to 96c27c7 Compare July 15, 2024 10:04
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_product branch from 96c27c7 to 60f7aa2 Compare November 18, 2024 07:04
@pilarvargas-tecnativa
Copy link
Contributor Author

@carlos-lopez-tecnativa Can you take a look please?

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 18, 2024
@pedrobaeza
Copy link
Member

cc @chienandalu

carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Nov 18, 2024
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

@chienandalu chienandalu Awaiting requested review from chienandalu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pilarvargas-tecnativa @pedrobaeza @chienandalu @carlos-lopez-tecnativa