[16.0][FIX] loyalty_criteria_multi_product: Avoiding cross-data in multi-product promotion criteria #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduct promotion criteria When setting up a multi-product promotion, you should not set a minimum spend amount because if one rule passes, they will all pass. To avoid misconfiguration, the field is hidden for promotions with multi-product criteria. In addition, the rule data is cleared when the criterion is changed so that the promotion is applied correctly in case of promotion modifications.
|
Hi @chienandalu, |
chienandalu
approved these changes
Nov 19, 2024
carlos-lopez-tecnativa
approved these changes
Nov 19, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at afa74ef. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up a multi-product promotion, you should not set a minimum spend amount because if one rule passes, they will all pass. To avoid misconfiguration, the field is hidden for promotions with multi-product criteria. In addition, the rule data is cleared when the criterion is changed so that the promotion is applied correctly in case of promotion modifications.
cc @Tecnativa
@carlos-lopez-tecnativa @chienandalu please review