[17.0][MIG] sale_elaboration: Migration to 17.0 #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peluko00
force-pushed
the
17.0-mig-sale_elaboration
branch
2 times, most recently
from
37463c7 to
ca75acc
Compare
…r changes product
…sale order view to store the value in onchange method
…inventory reporting
…to allow users display elaboration notes on delivery slips
… the elaborations
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_elaboration/
Currently translated at 100.0% (50 of 50 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_elaboration/es/
Without this patch, and with some unknown but feasible combination of sale-workflow modules, these steps were producing an exception:
1. Switch to mobile view.
2. Edit one sale order line.
3. Change packaging.
4. Save line (but not parent record).
5. Repeat steps 2-4.
The error was:
modifier "readonly": Unknown field state in domain
I'm not sure why just `state` wasn't working reliably, but I can tell Odoo upstream uses `parent.state` since odoo/odoo@a7883df and this fixes the issue.
@moduon MT-5351
Under certain circumstances, elaboration notes were deleted. For example, when adding or removing an elaboration. That's more or less OK, but also when delivery is installed along with this module, then the notes removal is unpredictable. Here I fix OCA#3154 by removing the computation on notes. Until now, notes were just repeating the same as we had in elaborations. Since the information was duplicated, the `elaboration_ids` field never appeared in reports. Now the notes are just a normal text field that does nothing if empty. Since it will be usually empty, now reports need to include `elaboration_ids` too. @moduon MT-6164
Currently translated at 100.0% (50 of 50 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_elaboration/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_elaboration/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_elaboration/it/
peluko00
force-pushed
the
17.0-mig-sale_elaboration
branch
from
ca75acc to
52fec70
Compare
|
/ocabot migration sale_elaboration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 17.0
cc https://github.com/APSL 159553
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review