-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_account_valuation_discrepancy_adjust #337
Open
AaronHForgeFlow
wants to merge
5
commits into
OCA:16.0
Choose a base branch
from
ForgeFlow:16.0-add-stock_account_valaution_report_discrepancy_adjust
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[16.0][ADD] stock_account_valuation_discrepancy_adjust #337
AaronHForgeFlow
wants to merge
5
commits into
OCA:16.0
from
ForgeFlow:16.0-add-stock_account_valaution_report_discrepancy_adjust
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
16.0-add-stock_account_valaution_report_discrepancy_adjust
branch
from
September 9, 2024 15:31
14f9eed
to
63f9129
Compare
LauraCForgeFlow
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MiquelRForgeFlow
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eate single journal entry
AaronHForgeFlow
force-pushed
the
16.0-add-stock_account_valaution_report_discrepancy_adjust
branch
from
November 11, 2024 10:24
36dc1b1
to
0208a15
Compare
…ds from the wizard as long they are slow computed an unnecessary to take a decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to add a module to fix discrepancies in the Dual inventory valuation report. The first attempt was this one: #175
This version is much simpler because the customer don't want to have a separate menu, I think it is not needed. The idea is they run the current report, and then the user uses the filter "Valuation Discrepancy" in order to see the products with discrepancies and apply the adjustments.
If users wants to do the adjustment in the past then they have to generate the Dual Inventory Valuation report in the past.
Added a small test also
Added the option to create a single journal entry if wanted.
cc @ForgeFlow