Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_scrap_tier_validation: Migration to 17.0 #1654

Open
wants to merge 13 commits into
base: 17.0
Choose a base branch
from

Conversation

StefanRijnhart
Copy link
Member

@StefanRijnhart StefanRijnhart commented Jul 11, 2024

Migration from 15.0.
We noticed that there is a minimal scrap view that is opened when scrapping directly from manufacturing orders or stock transfers. This view opens in a popup. The popup is only saved when confirming the scrap, which is a problem because if validation is required an exception will be raised with no option to save first and then request validation.

We're proposing to open the view in the main window instead. A glue module to fix the issue in compatibility with mrp.

@StefanRijnhart StefanRijnhart added this to the 17.0 milestone Jul 11, 2024
@StefanRijnhart StefanRijnhart changed the title [17.0][MIG] stock scrap tier validation: Migration to 17.0 [17.0][MIG] stock_scrap_tier_validation: Migration to 17.0 Aug 8, 2024
@StefanRijnhart StefanRijnhart force-pushed the 17.0-mig-stock_scrap_tier_validation branch from ddaceaa to cc9cb1e Compare October 3, 2024 16:01
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review 👍

@rousseldenis
Copy link
Contributor

/ocabot migration stock_scrap_tier_validation

@StefanRijnhart StefanRijnhart force-pushed the 17.0-mig-stock_scrap_tier_validation branch from cc9cb1e to 7e9edd7 Compare November 25, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants