[FIX] [16.0] stock_customer_deposit: Allow to add more deposits of the same product #1775
Conversation
|
Hi @rafaelbn, @EmilioPascual, |
Shide
force-pushed
the
16.0-increase_deposit-stock_customer_deposit
branch
2 times, most recently
from
d82e915
to
90daeb5
Compare
Shide
force-pushed
the
16.0-increase_deposit-stock_customer_deposit
branch
from
90daeb5
to
82d7e33
Compare
There was a problem hiding this comment.
Thank you @Shide ! 😄
I looks great! and works great ❤️ !
Just please I'm missing and improvement of the readme (the readme should explain everything that the code does 😃):
The module lets you add more stock deposits for a product without needing to fully consume the previous one. This simplifies managing inventory for clients with fluctuating needs.
- Improve README
There was a problem hiding this comment.
- stock_customer_deposit: Deposit Icon are hidded for salesman (video 2:00 min)
There was a problem hiding this comment.
Hey! I found a dangerous BUG!
This video shows an issue with customer deposits when selling 250 units of 'product' for a new deposit when there is already one then the moodule apply 100% discount to the new deposit! And it should be paid by the client. The module wrongly applies a 100% discount, making the product appear free.
- [BUG] stock_customer_deposit: Incorrect Discount Applied to New Sales Deposits (video 1 minute)
Alway with 💙
…xceeded sale order
|
@rafaelbn All requests attended. Done in separate commits because are thing that doesn't are related to the subject of this PR. |
There was a problem hiding this comment.
@Shide it's still buggy 😇
- [BUG] stock_customer_deposit: Incorrect Discount Applied to New Sales Deposits
Rev2: https://www.loom.com/share/4f76f39ef4074b738dd9acb04551143b?sid=8e017630-fee5-4c88-92b0-c1e19231e2cc
Only this detail, the rest is amazing! ❤️
Allows to add more deposits of the same product even if the customer already have a deposit.
Major refactoring in:
sale_order._check_can_customer_depositto perform the check all at once + simplifiedsale_order._action_confirmstock_move._action_assignto split casuistic and have a better control over the moves.float_comparewhen it's necessaryMT-7979 @moduon @EmilioPascual @rafaelbn @yajo @Gelojr @fcvalgar please review if you want :)