Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_picking_line_sequence model_create_multi #1861

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

andreampiovesana
Copy link

fix warning @api.model_create_multi

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please return the moves at the end of the create method. Also, squash commits and apply a conventionally formatted commit message (such as the title of the PR).

# We do not reset the sequence if we are copying a complete picking
# or creating a backorder
if not self.env.context.get("keep_line_sequence", False):
move.picking_id._reset_sequence()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, this should be done once per picking. This should be grouped per picking.

@StefanRijnhart
Copy link
Member

Picked an improved version of this in the migration of this module to 18.0 in #1864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants