Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] web_m2x_options: add 'ignore_m2x_options' option #3067

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Jan 23, 2025

Because the implementation “cannibalizes” the “search” method (it does not use super() to continue the execution chain). I add an option to be able to use other implementations (modules/widgets) in these fields in specific cases.

Simply add the option 'ignore_m2x_options'.

@Tardo Tardo changed the title [IMP] web_m2x_options: add 'ignore_m2x_options' option [14.0][IMP] web_m2x_options: add 'ignore_m2x_options' option Jan 23, 2025
@Tardo
Copy link
Member Author

Tardo commented Jan 31, 2025

ping @OCA/web-maintainers

Copy link

@admingrupoisonores admingrupoisonores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working correctly.

Copy link

@Neitherkx Neitherkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment

web_m2x_options/__manifest__.py Outdated Show resolved Hide resolved
@Tardo Tardo force-pushed the 14.0-imp-web_m2x_options branch from a1c3d89 to 4fdd8ee Compare February 6, 2025 11:58
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3067-by-CarlosRoca13-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1c0da4. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 84f06f7 into OCA:14.0 Feb 6, 2025
7 checks passed
@Tardo
Copy link
Member Author

Tardo commented Feb 6, 2025

@CarlosRoca13 thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants