Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] website_require_login: Migration to 17.0 #1038

Closed
wants to merge 21 commits into from
Closed

[17.0][MIG] website_require_login: Migration to 17.0 #1038

wants to merge 21 commits into from

Conversation

vvro
Copy link

@vvro vvro commented Mar 21, 2024

Tested the Website Login Required addon on 17.0 and it works with no modification.

@vvro vvro changed the title Website Login Required Addons works in 17.0 [17.0][MIG] Website Login Required Addons works in 17.0 Mar 21, 2024
@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

@vvro
Copy link
Author

vvro commented Mar 21, 2024

Okay, will try it out

vvro and others added 19 commits March 21, 2024 15:10
Currently translated at 100.0% (13 of 13 strings)

Translation: website-14.0/website-14.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_require_login/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/
Currently translated at 100.0% (13 of 13 strings)

Translation: website-16.0/website-16.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/
Currently translated at 61.5% (8 of 13 strings)

Translation: website-16.0/website-16.0-website_require_login
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_require_login/de/
@vvro vvro changed the title [17.0][MIG] Website Login Required Addons works in 17.0 [17.0][MIG] website_require_login: Migration to 17.0 Mar 21, 2024
@vvro
Copy link
Author

vvro commented Mar 21, 2024

@pedrobaeza This is okay? Or need something else?

@pedrobaeza
Copy link
Member

I'm afraid it's not correct, as the commit history is messed up starting with the addition of all files, then revert them, etc. And you should follow the rest of the guide for what to commit and with such names. It's better that you save the work, and start again from the scratch.

Anyway, I'm just telling you about the formal things. I'm not a qualified reviewer for the module itself.

@vvro
Copy link
Author

vvro commented Mar 21, 2024

I'm afraid it's not correct, as the commit history is messed up starting with the addition of all files, then revert them, etc. And you should follow the rest of the guide for what to commit and with such names. It's better that you save the work, and start again from the scratch.

Anyway, I'm just telling you about the formal things. I'm not a qualified reviewer for the module itself.

Okay will close this PR and start over.

@vvro vvro closed this Mar 21, 2024
@vvro vvro deleted the 17.0 branch March 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants