Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] website_odoo_debranding: Migration to 18.0 #1065

Open
wants to merge 29 commits into
base: 18.0
Choose a base branch
from

Conversation

NICO-SOLUTIONS
Copy link
Member

standard migration

cubells and others added 28 commits October 22, 2024 15:00
* Imported last updates from v8
* Adapted to v9
* Renamed to website_odoo_debranding
* Updated README
- Relicensed to LGPL.
- The template that does the job can be disabled by the admin.
[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-16.0/website-16.0-website_odoo_debranding
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_odoo_debranding/

[UPD] README.rst
With website_odoo_debranding installed it was not possible to install enterprise planning. Planning relies on <t t-call="web.brand_promotion_message"> sections which was removed with replacing the o_brand_promotion.

[UPD] Update website_odoo_debranding.pot

[BOT] post-merge updates
@BurkhalterY
Copy link
Member

Hi, I think this PR could be mark as ready. Threre is no breaking change at this point. What do you think? :)

@NICO-SOLUTIONS
Copy link
Member Author

Hi, I think this PR could be mark as ready. Threre is no breaking change at this point. What do you think? :)

Just havent had the time to check the failing tests. But this is not related to the module

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review November 20, 2024 07:04
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Nov 20, 2024
5 tasks
@pedrobaeza
Copy link
Member

The failure is for having this warning:

WARNING odoo odoo.tests.result: 0 failed, 0 error(s) of 0 tests when loading database 'odoo'

The workaround is to have an empty dummy test.

@NICO-SOLUTIONS
Copy link
Member Author

The failure is for having this warning:

WARNING odoo odoo.tests.result: 0 failed, 0 error(s) of 0 tests when loading database 'odoo'

The workaround is to have an empty dummy test.

@pedrobaeza ahh many thanks for the hint. Added the dummy test.
What about the "[IMP] website_odoo_debranding: pre-commit auto fixes" commit. There was no change by pre-commit. Better to squash this into the migration commit or keep it?

@pedrobaeza
Copy link
Member

Yes, remove that commit. I think you have added --allow-empty on your command line to have that commit.

@NICO-SOLUTIONS
Copy link
Member Author

Yes, remove that commit. I think you have added --allow-empty on your command line to have that commit.

this is correct. i was not sure how to handle the no-change, so added this commit temporarily.
its removed now. thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.