Fixing SecretStore reference for dex and minio on test #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computate
requested review from
larsks,
naved001,
tssala23,
dystewart,
schwesig and
IsaiahStapleton
schwesig
approved these changes
Nov 27, 2024
tssala23
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
The minio namespace will have to be added to the vault config for the test cluster, https://github.com/OCP-on-NERC/nerc-ocp-config/blob/main/vault/config/overlays/nerc-ocp-infra/config/nerc-ocp-test.yaml
There isn't a ClusterSecretStore in the nerc-ocp-test cluster, so we will use namespace SecretStores instead for dex and minio.
computate
force-pushed
the
test-minio
branch
from
c249092
to
62320bb
Compare
|
Thanks for catching that @tssala23, it's now there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a ClusterSecretStore in the nerc-ocp-test cluster, so we
will use namespace SecretStores instead for dex and minio.