Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile.cuda-torch: do NOT rm /build/core #1280

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Dockerfile.cuda-torch: do NOT rm /build/core #1280

merged 1 commit into from
Oct 1, 2024

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Oct 1, 2024

since we installed core in editable mode!

@bertsky
Dockerfile.cuda-torch: do NOT rm /build/core
1f5c4bb 
since we installed core in editable mode!
@bertsky bertsky requested a review from kba October 1, 2024 15:16
@bertsky
Copy link
Collaborator Author

bertsky commented Oct 1, 2024

Warrants a post-release IMO. Or, if possible, a quick follow-up with v2.69.1.

@bertsky
Copy link
Collaborator Author

bertsky commented Oct 1, 2024

Warrants a post-release IMO. Or, if possible, a quick follow-up with v2.69.1.

Or is that even necessary? We could just merge to master – the CD should pick this up and release on Dockerhub, overwriting the current latest and :v2.69.0, right?

@kba
Copy link
Member

kba commented Oct 1, 2024

Warrants a post-release IMO. Or, if possible, a quick follow-up with v2.69.1.

Or is that even necessary? We could just merge to master – the CD should pick this up and release on Dockerhub, overwriting the current latest and :v2.69.0, right?

Yep, that should be the case. Not the way it should be done but fine in this case :)

kba
kba approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kba kba merged commit a68782d into master Oct 1, 2024
22 checks passed
@kba kba deleted the fix-docker-cuda-torch branch October 1, 2024 16:06
@bertsky
Copy link
Collaborator Author

bertsky commented Oct 1, 2024

Yep, that should be the case. Not the way it should be done but fine in this case :)

It did work!

Updated 4 minutes ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertsky @kba