-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generateds gdscollector #576
base: master
Are you sure you want to change the base?
Conversation
8639b16
to
9766f93
Compare
9766f93
to
1b3a721
Compare
2c59b8e
to
7c6831c
Compare
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 84.93% 83.43% -1.51%
==========================================
Files 52 54 +2
Lines 2941 3012 +71
Branches 572 584 +12
==========================================
+ Hits 2498 2513 +15
- Misses 332 387 +55
- Partials 111 112 +1
Continue to review full report at Codecov.
|
We discussed this briefly in yesterday's tech call: now that we have a |
Here's the initial work on extending generateDS' GdsCollector to offer more helpful help messages.
This replaces the buildin
parse/parseString
methods with variants that know about the filename (and passes it on to OcrdGdsCollector.OcrdGdsCollector should probably have the same interface, i.e. inherit from ValidationReport (which needs to support an alias
add_message
->add_error
).Now that the foundations are here, we can discuss what kind of information should be captured and how messages should be formatted.