Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generateds gdscollector #576

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Generateds gdscollector #576

wants to merge 11 commits into from

Conversation

kba
Copy link
Member

@kba kba commented Aug 24, 2020

Here's the initial work on extending generateDS' GdsCollector to offer more helpful help messages.

This replaces the buildin parse/parseString methods with variants that know about the filename (and passes it on to OcrdGdsCollector.

OcrdGdsCollector should probably have the same interface, i.e. inherit from ValidationReport (which needs to support an alias add_message -> add_error).

Now that the foundations are here, we can discuss what kind of information should be captured and how messages should be formatted.

@kba kba force-pushed the generateds-gdscollector branch from 9766f93 to 1b3a721 Compare October 6, 2020 09:51
@kba kba force-pushed the generateds-gdscollector branch from 2c59b8e to 7c6831c Compare October 6, 2020 12:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

Merging #576 into master will decrease coverage by 1.50%.
The diff coverage is 21.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   84.93%   83.43%   -1.51%     
==========================================
  Files          52       54       +2     
  Lines        2941     3012      +71     
  Branches      572      584      +12     
==========================================
+ Hits         2498     2513      +15     
- Misses        332      387      +55     
- Partials      111      112       +1     
Impacted Files Coverage Δ
ocrd_models/ocrd_page_parse.py 0.00% <0.00%> (ø)
ocrd_models/ocrd_models/generatedscollector.py 68.18% <68.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a1318...9662522. Read the comment docs.

@bertsky
Copy link
Collaborator

bertsky commented Oct 9, 2020

Now that the foundations are here, we can discuss what kind of information should be captured and how messages should be formatted.

We discussed this briefly in yesterday's tech call: now that we have a ValidationReport along with the PAGE object, which makes validation errors actionable (without the need to repeat validation in dedicated tools/steps), we could add hooks to to_xml for post-processing (e.g. coordinate repair). As a first step, this could be setting negative points to zero automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants