fix regression issue.

[ElizabethOkerio]

Issues

This pull request fixes #2745.

Description

Briefly describe the changes of this pull request.

With the bulk operations we added logic for ensuring that the ODataIdContainer does not get written on the response payload. And the ODataIdContainer is represented as a complex property on the EdmModel. The logic that was added was to get the ClrType then we check whether it is of type ODataIdContainer.

IEdmTypeReference type = complexProperty.Key == null ? null : complexProperty.Key.Type;
if (type != null && resourceContext.EdmModel != null)
{
    Type clrType = EdmLibHelpers.GetClrType(type.AsStructured(), resourceContext.EdmModel);
}

doing type.AsStructured() on a collection of complex types returns a BadEntityTypeReference error. We pass this error to the GetClrType method which end ups doing some expensive computations trying to find the ClrType.

This fix ensures that type.AsStructured() is not performed on collections of complex properties.

This is how the WriteComplexPropertiesAsync performs before the fix

Function Name	Total CPU [unit, %]	Self CPU [unit, %]	Module	Category
||||||||||||||||||||||| + Microsoft.AspNet.OData.Formatter.Serialization.ODataResourceSerializer.WriteComplexPropertiesAsync()	141 (11.60%)	2 (0.16%)	microsoft.aspnetcore.odata

And this is how it performs after the fix:

Function Name	Total CPU [unit, %]	Self CPU [unit, %]	Module	Category
||||||||||||||||||||||| + Microsoft.AspNet.OData.Formatter.Serialization.ODataResourceSerializer.WriteComplexPropertiesAsync()	30 (2.87%)	1 (0.10%)	microsoft.aspnetcore.odata

Checklist (Uncheck if it is not completed)

• Test cases added
• Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

[pull-request-quantifier-deprecated]

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Small
Size       : +2 -2
Percentile : 1.6%

Total files changed: 1

Change summary by file extension:
.cs : +2 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[robertmclaws]

If you folks upgraded your toolset to the latest Visual Studio and C# language version, in your code sample above you could start using is null instead of == null and you would get better performance.