Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406
The issue was that in
scikit-learn 1.3
they added a new feature to decision trees to deal with missing data. This broke our serialization ofscikit-learn
models to json. The reason this was not detected in our regular tests but in the weekly Hades tests is that there was inconsistency in how python environments were set up for testing. It was hardcoded in our regular test github actions to usepython 3.7
, which has gone out of support. This resulted in our tests using an older version ofscikit-learn
which didn't have this issue.In this PR I've
scikit-learn 1.3
and older versions.configurePython
function for consistency22.04
which is the latest long-term supported release. This was necessary since otherwise a system library needed to be updated forscipy
to work correctly inpython 3.11
Now the tests test against the default python version in
conda
, which at this moment ispython 3.11
. Other option would be to hardcode somehere a different python version to test against. But I'd expect versions3.8-3.11
to work currently.@jreps could you review/approve this?