assign population if existing and added a test #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
===========================================
+ Coverage 89.32% 89.37% +0.04%
===========================================
Files 49 49
Lines 9830 9831 +1
===========================================
+ Hits 8781 8786 +5
+ Misses 1049 1045 -4 ☔ View full report in Codecov by Sentry. |
egillax
added a commit
that referenced
this pull request
Apr 5, 2024
* Update DESCRIPTION * only resrtict to first if many observations per subjectId * fix assignment operator in configurePython (#421) * Tibble dependancy removal (#422) * remove unnecessary remotes (#423) * Study population improvements (#424) * assign population if existing and added a test (#428) * 429 save cdm database name (#430) * save dev database name and schema in trainDetails (#434) * preserve attributes when splitting data * Prevent plpData from being evaluated during do.call (#436) * test improvements (#438) * fix duplicate vignette titles --------- Co-authored-by: jreps <[email protected]> Co-authored-by: Henrik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed my own mistake - didn't assign the population object correctly in the last PR. Added a unit tests that tests when we use an existing population in our code.